Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 2041522:[release-4.9] controllers: remove odf CSV as a owner to other CSV's and add odf sub #167

Merged
merged 1 commit into from Jan 18, 2022
Merged

Bug 2041522:[release-4.9] controllers: remove odf CSV as a owner to other CSV's and add odf sub #167

merged 1 commit into from Jan 18, 2022

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #166

/assign agarwal-mudit

@iamniting
controllers: remove odf CSV as a owner to other CSV's and add odf sub
0fd4110 
while upgrading odf-operator odf-operator csv get deleted and replaced
with the new one. which cause ocs-operator, mcg-operator to be deleted
as the odf-operator csv was the owner to the ocs-operator, mcg-operator.

To prevent ocs-operator, mcg-operator to be deleted we need to remove
odf-operator CSV as a owner and add odf-operator subscription as a owner
for the garbage collector.

Signed-off-by: Nitin Goyal <nigoyal@redhat.com>
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jan 17, 2022
Merged
@agarwal-mudit
Copy link
Member

/hold
Till we have acks

@iamniting iamniting changed the title [release-4.9] controllers: remove odf CSV as a owner to other CSV's and add odf sub Bug 2041522:[release-4.9] controllers: remove odf CSV as a owner to other CSV's and add odf sub Jan 17, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 17, 2022

@openshift-cherrypick-robot: This pull request references Bugzilla bug 2041522, which is invalid:

  • expected the bug to target the "ODF 4.9.2" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 2041522:[release-4.9] controllers: remove odf CSV as a owner to other CSV's and add odf sub

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@iamniting
Copy link
Member

/test odf-operator-bundle-e2e-aws

@agarwal-mudit
Copy link
Member

/bugzilla refresh

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 18, 2022

@agarwal-mudit: This pull request references Bugzilla bug 2041522, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (ODF 4.9.2) matches configured target release for branch (ODF 4.9.2)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @ebenahar

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested a review from ebenahar January 18, 2022 10:22
@agarwal-mudit
Copy link
Member

/hold cancel

@agarwal-mudit
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 18, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 18, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: agarwal-mudit, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 18, 2022
@iamniting iamniting merged commit 568484e into red-hat-storage:release-4.9 Jan 18, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 18, 2022

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged:

Bugzilla bug 2041522 has been moved to the MODIFIED state.

In response to this:

Bug 2041522:[release-4.9] controllers: remove odf CSV as a owner to other CSV's and add odf sub

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ebenahar ebenahar Awaiting requested review from ebenahar

Assignees

@agarwal-mudit agarwal-mudit

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high bugzilla/valid-bug lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@openshift-cherrypick-robot @agarwal-mudit @iamniting