controllers: change controller ref to owner ref of the vendor system #172
Conversation
bindrad
changed the title
There was a problem hiding this comment.
Hi Dhruv, Changes looks good to me, CI is also passed, Can we pls change a commit-msg with something descriptive. eg.
controllers: change controller ref to owner ref of the vendor system
We are using the controller ref to show the vendor CR in the OCP UI
and can also use the owner ref for the same.
controller ref is required by the managed services as storageCluster
is created by them in the manages services.
changing the controller ref to owner ref will solve the managed
services problem.
BZ: https://bugzilla.redhat.com/show_bug.cgi?id=2044447
We are using the controller ref to show the vendor CR in the OCP UI and can also use the owner ref for the same. controller ref is required by the managed services as storageCluster is created by them in the manages services. changing the controller ref to owner ref will solve the managed services problem. BZ: https://bugzilla.redhat.com/show_bug.cgi?id=2044447 Signed-off-by: bindrad <dbindra@redhat.com>
bindrad
changed the title
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bindrad, iamniting The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/cherry-pick release-4.10 |
|
@agarwal-mudit: new pull request could not be created: failed to create pull request against red-hat-storage/odf-operator#release-4.10 from head openshift-cherrypick-robot:cherry-pick-172-to-release-4.10: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"No commits between red-hat-storage:release-4.10 and openshift-cherrypick-robot:cherry-pick-172-to-release-4.10"}],"documentation_url":"https://docs.github.com/rest/reference/pulls#create-a-pull-request"} In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
No need to cherry-pick, change is already there in release-4.10 |
We are using the controller ref to show the vendor CR in the OCP UI and can also use the owner ref for the same.
controller ref is required by the managed services as storageCluster is created by them in the manages services.
changing the controller ref to owner ref will solve the managed services problem.
BZ: https://bugzilla.redhat.com/show_bug.cgi?id=2044447
Signed-off-by: bindrad dbindra@redhat.com