Use a unique label for monitoring resources

[afreen23]

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=2043034

Issue

Both csi-addon operator and odf-operator are using the default label and label-selector provided by operator-sdk - "control-plane: controller-manager" for its services and deployments.
This is allowing deployments, services and service monitors of each operator to select the pods ans services of other operator.
One critical impact of this is in UI monitoring where odf metrics monitor is picking up csiaddon service and hence showing an extra storage system. This is breaking the prometheus query and hence missing storage system on UI.

Fix

Use a unique label selector in odf-operator to avoid conflicts.

Before:

After:

[openshift-ci]

@afreen23: This pull request references Bugzilla bug 2043034, which is valid.

No validations were run on this bug

Requesting review from QA contact:
/cc @ebenahar

In response to this:

Bug 2043034: Use a unique label for monitoring resources

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[afreen23]

@iamniting @umangachapagain please review

[openshift-ci]

@afreen23: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

Use a unique label for monitoring resources

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[iamniting]

@afreen23 changes look good to me as they are really simple, But I have questions before I give LGTM.

1. Will this require a change in the openshift 4.10 console code too.
2. If yes Will openshift console code work with the odf 4.9 until we release 4.10 as openshift gets released before odf.
3. or this has nothing to do with the openshift console code and matches labels b/w themselves.

[iamniting]

/cherry-pick release-4.10

[openshift-cherrypick-robot]

@iamniting: once the present PR merges, I will cherry-pick it on top of release-4.10 in a new PR and assign it to you.

In response to this:

/cherry-pick release-4.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[afreen23]

@afreen23 changes look good to me as they are really simple, But I have questions before I give LGTM.

1. Will this require a change in the openshift 4.10 console code too.
2. If yes Will openshift console code work with the odf 4.9 until we release 4.10 as openshift gets released before odf.
3. or this has nothing to do with the openshift console code and matches labels b/w themselves.

Thanks for the review @iamniting
No change is required in openshift 4.10 console code .

Details:
The prometheus query used on dashboard is failing currently. odf_system_map query is listing two storage systems (due to #178 (comment)) and when we join it with another query it starts failing since many to many matching occurs.

[openshift-ci]

@afreen23: This pull request references Bugzilla bug 2043034, which is valid.

No validations were run on this bug

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (musoni@redhat.com), skipping review request.

In response to this:

Bug 2043034: Use a unique label for monitoring resources

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci]

@afreen23: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

Use a unique label for monitoring resources

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[iamniting]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: afreen23, iamniting

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [iamniting]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-cherrypick-robot]

@iamniting: new pull request created: #180

In response to this:

/cherry-pick release-4.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.