Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 2043034:[release-4.10] Use a unique label for monitoring resources #180

Conversation

openshift-cherrypick-robot

This is an automated cherry-pick of #178

/assign iamniting

csi-addon operator and odf-operator are using the default label and
labelSelector provided by operator-sdk:control-plane:controller-manager
for its services. This is allowing deployments, services and service
monitors of each operator to select the pods and services of other
operator.One critical impact of this is in UI dashboard where odf
service monitor is picking up csiaddon service and hence showing an
extra storage system.

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=2043034

Signed-off-by: Afreen Rahman <afrahman@redhat.com>
@iamniting iamniting changed the title [release-4.10] Use a unique label for monitoring resources Bug 2043034:[release-4.10] Use a unique label for monitoring resources Feb 24, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 24, 2022

@openshift-cherrypick-robot: This pull request references Bugzilla bug 2043034, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (ODF 4.10.0) matches configured target release for branch (ODF 4.10.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (musoni@redhat.com), skipping review request.

In response to this:

Bug 2043034:[release-4.10] Use a unique label for monitoring resources

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Member

@iamniting iamniting left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 24, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 24, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: iamniting, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 24, 2022
@openshift-merge-robot openshift-merge-robot merged commit 2bd4a3f into red-hat-storage:release-4.10 Feb 24, 2022
17 of 18 checks passed
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 24, 2022

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged:

Bugzilla bug 2043034 has been moved to the MODIFIED state.

In response to this:

Bug 2043034:[release-4.10] Use a unique label for monitoring resources

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high bugzilla/valid-bug lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants