Prevent subscription config override if it is not empty

[tangledbytes]

Description

This PR prevents subscription config override if it is not empty. This change was made in order to allow users to be able to edit subscription if there is a need for the same (for eg. adding tolerations to underlying objects, etc.)

Test

Following steps were taken to test the changes

1. Steps in the README were followed to deploy ODF with OLM on an OpenShift Cluster.
2. MCG Subscription was edited to add a toleration
3. Manual inspection of subscription confirmed that the config were no longer overridden.
4. Manual inspection of NooBaa operation confirmed that the toleration was propagated to the operator and was persisted.

Signed-off-by: Utkarsh Srivastava srivastavautkarsh8097@gmail.com

https://bugzilla.redhat.com/show_bug.cgi?id=2122980

[openshift-ci]

Hi @utkarsh-pro. Thanks for your PR.

I'm waiting for a red-hat-storage member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[iamniting]

/lgtm
/ok-to-test

[iamniting]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: iamniting, utkarsh-pro

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [iamniting]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[iamniting]

/ok-to-test

[iamniting]

/cherry-pick release-4.11

[openshift-cherrypick-robot]

@iamniting: new pull request created: #257

In response to this:

/cherry-pick release-4.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[iamniting]

/cherry-pick release-4.10

[openshift-cherrypick-robot]

@iamniting: new pull request created: #262

In response to this:

/cherry-pick release-4.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.