Bug 2174335:[release-4.12] Remove namespace dependency from the configmap and inject it in the deployment #304
Conversation
Add new variable `OPERATOR_CATALOGSOURCE_NAMESPACE` in the makefile for specifying the catalog source namespace. Signed-off-by: Nitin Goyal <nigoyal@redhat.com>
Adding the OPERATOR_NAMESPACE constant value to the configmap causes few issues if we deploy the operator in any other namespace. Because this value is set at the build time, it cannot be changed while the operator is being deployed. Instead, we'll include this environment variable in the deployment and set its value using the downward API. Signed-off-by: Nitin Goyal <nigoyal@redhat.com>
Make use of the k8s downward APIs to set the OPERATOR-NAMESPACE. Even if we do not run the operator in the openshift-storage namespace, it will always return the correct namespace to us. Signed-off-by: Nitin Goyal <nigoyal@redhat.com>
Signed-off-by: Nitin Goyal <nigoyal@redhat.com>
Signed-off-by: Nitin Goyal <nigoyal@redhat.com>
Allow odf-operator to install in any namespace using the kustomize. Signed-off-by: Nitin Goyal <nigoyal@redhat.com>
Signed-off-by: Nitin Goyal <nigoyal@redhat.com>
Signed-off-by: Nitin Goyal <nigoyal@redhat.com>
Signed-off-by: Nitin Goyal <nigoyal@redhat.com>
iamniting
changed the title
|
@openshift-cherrypick-robot: This pull request references Bugzilla bug 2174335, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/bugzilla refresh |
|
@iamniting: This pull request references Bugzilla bug 2174335, which is valid. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Bugzilla (ebenahar@redhat.com), skipping review request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/test odf-operator-bundle-e2e-aws |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: iamniting, openshift-cherrypick-robot The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
openshift-merge-robot
merged commit 673f1fd
into
red-hat-storage:release-4.12
|
@openshift-cherrypick-robot: Some pull requests linked via external trackers have merged: The following pull requests linked via external trackers have not merged: These pull request must merge or be unlinked from the Bugzilla bug in order for it to move to the next state. Once unlinked, request a bug refresh with Bugzilla bug 2174335 has not been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This is an automated cherry-pick of #277
/assign iamniting