Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add description in the console installation wizard #84

Merged
merged 3 commits into from Sep 9, 2021
Merged

Add description in the console installation wizard #84

merged 3 commits into from Sep 9, 2021

Conversation

iamniting
Copy link
Member

@iamniting
bundle: remove file name and keep directory for csv changes
43d078b 
This will allow us to use kustomize and divide the data in the csv also.

Signed-off-by: Nitin Goyal <nigoyal@redhat.com>
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 9, 2021
@iamniting
bundle: segregate icon and description from csv and add into new files
f536cc4 
Use the kustomize to populate the data.

Signed-off-by: Nitin Goyal <nigoyal@redhat.com>
@iamniting
bundle: update bundle manifests
07d9aa9 
Output of `make bundle`.

Signed-off-by: Nitin Goyal <nigoyal@redhat.com>
@iamniting
Copy link
Member Author

Output

Screenshot from 2021-09-09 15-18-10

@iamniting iamniting added the backport-release-4.9 Indicate PR requires to be backported label Sep 9, 2021
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 9, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 9, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: iamniting, jarrpa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jarrpa
Copy link
Member

jarrpa commented Sep 9, 2021

/override ci/prow/odf-operator-bundle-e2e-aws

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 9, 2021

@jarrpa: Overrode contexts on behalf of jarrpa: ci/prow/odf-operator-bundle-e2e-aws

In response to this:

/override ci/prow/odf-operator-bundle-e2e-aws

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jarrpa jarrpa merged commit 2f2f469 into red-hat-storage:main Sep 9, 2021
@jarrpa
Copy link
Member

jarrpa commented Sep 9, 2021

/cherrypick release-4.9

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Sep 9, 2021
Merged
@openshift-cherrypick-robot
Copy link

@jarrpa: new pull request created: #85

In response to this:

/cherrypick release-4.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@iamniting iamniting deleted the card branch September 17, 2021 08:40
@openshift-ci openshift-ci bot mentioned this pull request Nov 15, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jarrpa jarrpa jarrpa approved these changes

Assignees

@jarrpa jarrpa

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-release-4.9 Indicate PR requires to be backported lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@iamniting @jarrpa @openshift-cherrypick-robot