Bug 2138855: Set PeerReady condition status to false upon relocation initiation #121
Conversation
Previously, the PeerReady condition status was set to false after the relocation setup between the source and target clusters was completed and before entering the clean up phase. This led to a misleading indication that the peer was ready for a new action before getting to that point. Consequently, users can initiate another action, assuming that the PeerReady condition being true meant it was ready for the next step. To rectify this issue, this commit ensures that as soon as the relocation action is initiated, the PeerReady condition status is immediately switched to false. This change accurately reflects the actual readiness of the peer, preventing any misconceptions about initiating additional actions prematurely. Signed-off-by: Benamar Mekhissi <bmekhiss@ibm.com> (cherry picked from commit 521f7b6)
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: BenamarMk The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@BenamarMk: This pull request references Bugzilla bug 2138855, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Bugzilla (sagrawal@redhat.com), skipping review request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
BenamarMk
merged commit 347ced0
into
red-hat-storage:release-4.14
|
@BenamarMk: All pull requests linked via external trackers have merged: Bugzilla bug 2138855 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Previously, the PeerReady condition status was set to false after the relocation setup between the source and target clusters was completed and before entering the clean up phase. This led to a misleading indication that the peer was ready for a new action before getting to that point. Consequently, users can initiate another action, assuming that the PeerReady condition being true meant it was ready for the next step.
To rectify this issue, this commit ensures that as soon as the relocation action is initiated, the PeerReady condition status is immediately switched to false. This change accurately reflects the actual readiness of the peer, preventing any misconceptions about initiating additional actions prematurely.
Signed-off-by: Benamar Mekhissi bmekhiss@ibm.com
(cherry picked from commit 521f7b6)