Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 2058207: Add OCM backup label to DRPolicy resources #14

Merged
merged 12 commits into from Feb 25, 2022

Conversation

ShyamsundarR
Copy link

Also, refactored the code a little to reuse common
functions across DRPC and DRPolicy.

Adding the label to the config map is pending, which
needs to happen once we start watching it for changes
and update dr-cluster with the new config map.

Additional cherry picks in PR is for various envtest changes that enable
better sanity testing of code, does not impact/change packaged deliverables.

Signed-off-by: Shyamsundar Ranganathan srangana@redhat.com
(cherry picked from commit e5e91bf)

ShyamsundarR and others added 12 commits February 25, 2022 07:23
Updated DRPolicy to add a "region" for each cluster
Updated VRG with required "async" section

Signed-off-by: Shyamsundar Ranganathan <srangana@redhat.com>
(cherry picked from commit 888190b)
Signed-off-by: hatfieldbrian <bhatfiel@redhat.com>
(cherry picked from commit 499fcdd)
…/stolostron

Signed-off-by: hatfieldbrian <bhatfiel@redhat.com>
(cherry picked from commit 1321f78)
Signed-off-by: hatfieldbrian <bhatfiel@redhat.com>
(cherry picked from commit 6fb32b8)
Co-Authored-by: Raghavendra M <raghavendra@redhat.com>
Signed-off-by: Raghavendra Talur <raghavendra.talur@gmail.com>
(cherry picked from commit a9440b0)
Co-Authored-by: Raghavendra M <raghavendra@redhat.com>
Signed-off-by: Raghavendra Talur <raghavendra.talur@gmail.com>
(cherry picked from commit 2247f84)
Co-Authored-by: Raghavendra M <raghavendra@redhat.com>
Signed-off-by: Raghavendra Talur <raghavendra.talur@gmail.com>
(cherry picked from commit abf71dd)
Co-Authored-by: Raghavendra M <raghavendra@redhat.com>
Signed-off-by: Raghavendra Talur <raghavendra.talur@gmail.com>
(cherry picked from commit ee54f09)
Co-Authored-by: Raghavendra M <raghavendra@redhat.com>
Signed-off-by: Raghavendra Talur <raghavendra.talur@gmail.com>
(cherry picked from commit de1788d)
Co-Authored-by: Raghavendra M <raghavendra@redhat.com>
Signed-off-by: Raghavendra Talur <raghavendra.talur@gmail.com>
(cherry picked from commit 84b8e1d)
…minutes

Signed-off-by: hatfieldbrian <bhatfiel@redhat.com>
(cherry picked from commit ff29bf0)
Also, refactored the code a little to reuse common
functions across DRPC and DRPolicy.

Adding the label to the config map is pending, which
needs to happen once we start watching it for changes
and update dr-cluster with the new config map.

Signed-off-by: Shyamsundar Ranganathan <srangana@redhat.com>
(cherry picked from commit e5e91bf)
@openshift-ci
Copy link

openshift-ci bot commented Feb 25, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ShyamsundarR

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link

openshift-ci bot commented Feb 25, 2022

@ShyamsundarR: This pull request references Bugzilla bug 2058207, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (ODF 4.10.0) matches configured target release for branch (ODF 4.10.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @keesturam

In response to this:

Bug 2058207: Add OCM backup label to DRPolicy resources

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link

openshift-ci bot commented Feb 25, 2022

@openshift-ci[bot]: GitHub didn't allow me to request PR reviews from the following users: keesturam.

Note that only red-hat-storage members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

@ShyamsundarR: This pull request references Bugzilla bug 2058207, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (ODF 4.10.0) matches configured target release for branch (ODF 4.10.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @keesturam

In response to this:

Bug 2058207: Add OCM backup label to DRPolicy resources

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@agarwal-mudit agarwal-mudit merged commit 2adf094 into red-hat-storage:release-4.10 Feb 25, 2022
@openshift-ci
Copy link

openshift-ci bot commented Feb 25, 2022

@ShyamsundarR: All pull requests linked via external trackers have merged:

Bugzilla bug 2058207 has been moved to the MODIFIED state.

In response to this:

Bug 2058207: Add OCM backup label to DRPolicy resources

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ShyamsundarR ShyamsundarR deleted the bz2058207 branch June 8, 2022 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants