Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 2058211: Validate CIDRs format in DRPolicy #15

Merged
merged 8 commits into from Feb 25, 2022
Merged

Bug 2058211: Validate CIDRs format in DRPolicy #15

merged 8 commits into from Feb 25, 2022

Conversation

ShyamsundarR
Copy link

Add validation to CIDR format in DRPolicy

Also cherry picked changes as follows:

  • Changed to move to ACM downstream repository stolostron from open-cluster-management
    • This change is to accommodate changes by ACM to rename their downstream repository
  • Additional test files changes to accommodate future PRs that add more tests to the code base

Signed-off-by: rakeshgm rakeshgm@redhat.com
(cherry picked from commit 1afde40)
(cherry picked from commit 79d777b)

ShyamsundarR and others added 8 commits February 25, 2022 07:53
@ShyamsundarR
Move to stolostron
b6bac31 
Also add policy related dependenciess
Move to go 1.16 across the docker and make files

Signed-off-by: Shyamsundar Ranganathan <srangana@redhat.com>
(cherry picked from commit 6ae35d6)
@rakeshgm @ShyamsundarR
hack/olm: disable shellcheck #1091
151e72c 
Signed-off-by: rakeshgm <rakeshgm@redhat.com>
(cherry picked from commit c10eaf8)
@raghavendra-talur @ShyamsundarR
Add DRPC test for sync mode
3642d14 
Co-Authored-by: Raghavendra M <raghavendra@redhat.com>
Signed-off-by: Raghavendra Talur <raghavendra.talur@gmail.com>
(cherry picked from commit df8db5a)
@ShyamsundarR
DRPC test: Added DRPC test for relocation then failover and so on in …
2820b18 
…sync mode.

Addressed the review comments and made required changes to keep the
linter work as expected.
Fixed vrg delete to happen on Primary.
Signe-off-by: Jolly Mishra <jmishra@redhat.com>

(cherry picked from commit 10f8ca6)
@ShyamsundarR
DRPC Test: Added few function which will be called during
0eb6498 
failover, relocate and clearing drpc after failover and relocate

Signed-off-by: Jolly Mishra <jmishra@redhat.com>
(cherry picked from commit e3116c0)
@rakeshgm @ShyamsundarR
api/config/samples: add metrodr_drpolicy example
1554a53 
Signed-off-by: rakeshgm <rakeshgm@redhat.com>
(cherry picked from commit b9a7f36)
@rakeshgm @ShyamsundarR
drpolicy: validate CIDRs format
f56b8c3 
Signed-off-by: rakeshgm <rakeshgm014@gmail.com>
(cherry picked from commit 79d777b)
@rakeshgm @ShyamsundarR
drpolicy_controller_test: add CIDRs validate tests
9a0c419 
Signed-off-by: rakeshgm <rakeshgm@redhat.com>
(cherry picked from commit 1afde40)
@openshift-ci
Copy link

openshift-ci bot commented Feb 25, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ShyamsundarR

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link

openshift-ci bot commented Feb 25, 2022

@ShyamsundarR: This pull request references Bugzilla bug 2058211, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (ODF 4.10.0) matches configured target release for branch (ODF 4.10.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @keesturam

In response to this:

Bug 2058211: Validate CIDRs format in DRPolicy

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link

openshift-ci bot commented Feb 25, 2022

@openshift-ci[bot]: GitHub didn't allow me to request PR reviews from the following users: keesturam.

Note that only red-hat-storage members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

@ShyamsundarR: This pull request references Bugzilla bug 2058211, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (ODF 4.10.0) matches configured target release for branch (ODF 4.10.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @keesturam

In response to this:

Bug 2058211: Validate CIDRs format in DRPolicy

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@agarwal-mudit agarwal-mudit merged commit 0827b28 into red-hat-storage:release-4.10 Feb 25, 2022
@openshift-ci
Copy link

openshift-ci bot commented Feb 25, 2022

@ShyamsundarR: All pull requests linked via external trackers have merged:

Bugzilla bug 2058211 has been moved to the MODIFIED state.

In response to this:

Bug 2058211: Validate CIDRs format in DRPolicy

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ShyamsundarR ShyamsundarR deleted the bz2058211 branch June 8, 2022 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agarwal-mudit agarwal-mudit Awaiting requested review from agarwal-mudit

Assignees
No one assigned
Labels
bugzilla/severity-high bugzilla/valid-bug
Projects
None yet
Milestone
No milestone
4 participants
@ShyamsundarR @agarwal-mudit @rakeshgm @raghavendra-talur