Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 2068401: Avoid overwriting needsStatusUpdate #27

Merged
merged 1 commit into from Mar 29, 2022

Conversation

ShyamsundarR
Copy link

Ensure previous conditions requiring status
updates are preserved, when a future condition
does not require a status update.

This helps with retaining last known good status
for DRPC "Available" condition, and also prevents
future conditions from overwriting the same.

Was inadvertently introduced in commit 90d1d91

Signed-off-by: Shyamsundar Ranganathan srangana@redhat.com

Ensure previous conditions requiring status
updates are preserved, when a future condition
does not require a status update.

This helps with retaining last known good status
for DRPC "Available" condition, and also prevents
future conditions from overwriting the same.

Was inadvertently introduced in commit 90d1d91

Signed-off-by: Shyamsundar Ranganathan <srangana@redhat.com>
@openshift-ci
Copy link

openshift-ci bot commented Mar 28, 2022

@ShyamsundarR: This pull request references Bugzilla bug 2068401, which is invalid:

  • expected the bug to target the "ODF 4.10.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 2068401: Avoid overwriting needsStatusUpdate

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@raghavendra-talur
Copy link
Collaborator

/approve

@openshift-ci
Copy link

openshift-ci bot commented Mar 28, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: raghavendra-talur, ShyamsundarR

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

@openshift-ci
Copy link

openshift-ci bot commented Mar 29, 2022

@openshift-bot: This pull request references Bugzilla bug 2068401, which is invalid:

  • expected the bug to target the "ODF 4.10.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@agarwal-mudit
Copy link
Member

/bugzilla refresh

@openshift-ci
Copy link

openshift-ci bot commented Mar 29, 2022

@agarwal-mudit: This pull request references Bugzilla bug 2068401, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (ODF 4.10.0) matches configured target release for branch (ODF 4.10.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @keesturam

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link

openshift-ci bot commented Mar 29, 2022

@openshift-ci[bot]: GitHub didn't allow me to request PR reviews from the following users: keesturam.

Note that only red-hat-storage members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

@agarwal-mudit: This pull request references Bugzilla bug 2068401, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (ODF 4.10.0) matches configured target release for branch (ODF 4.10.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @keesturam

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@agarwal-mudit agarwal-mudit merged commit e0e0797 into red-hat-storage:release-4.10 Mar 29, 2022
@openshift-ci
Copy link

openshift-ci bot commented Mar 29, 2022

@ShyamsundarR: All pull requests linked via external trackers have merged:

Bugzilla bug 2068401 has been moved to the MODIFIED state.

In response to this:

Bug 2068401: Avoid overwriting needsStatusUpdate

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ShyamsundarR ShyamsundarR deleted the bz2068401 branch June 8, 2022 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants