New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 2068401: Avoid overwriting needsStatusUpdate #27
Bug 2068401: Avoid overwriting needsStatusUpdate #27
Conversation
Ensure previous conditions requiring status updates are preserved, when a future condition does not require a status update. This helps with retaining last known good status for DRPC "Available" condition, and also prevents future conditions from overwriting the same. Was inadvertently introduced in commit 90d1d91 Signed-off-by: Shyamsundar Ranganathan <srangana@redhat.com>
|
@ShyamsundarR: This pull request references Bugzilla bug 2068401, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: raghavendra-talur, ShyamsundarR The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/bugzilla refresh Recalculating validity in case the underlying Bugzilla bug has changed. |
|
@openshift-bot: This pull request references Bugzilla bug 2068401, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/bugzilla refresh |
|
@agarwal-mudit: This pull request references Bugzilla bug 2068401, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@openshift-ci[bot]: GitHub didn't allow me to request PR reviews from the following users: keesturam. Note that only red-hat-storage members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@ShyamsundarR: All pull requests linked via external trackers have merged: Bugzilla bug 2068401 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Ensure previous conditions requiring status
updates are preserved, when a future condition
does not require a status update.
This helps with retaining last known good status
for DRPC "Available" condition, and also prevents
future conditions from overwriting the same.
Was inadvertently introduced in commit 90d1d91
Signed-off-by: Shyamsundar Ranganathan srangana@redhat.com