Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 2074510: Add RBAC role for PlacementDecision resource #28

Merged
merged 2 commits into from Apr 15, 2022

Conversation

ShyamsundarR
Copy link

This commit fixes https://bugzilla.redhat.com/show_bug.cgi?id=2071494.

The PlacmentRule has been changed and now generates a placementDecision in the same namespace.
The subscription watches the PlacementDecision changes and deploy the application to the
managed clusters accordingly. The PlacementRule controller needs to be granted access to the
PlacementDecision resource.

(cherry picked from commit 8bc39e1)

This commit fixes https://bugzilla.redhat.com/show_bug.cgi?id=2071494.
The PlacmentRule has been changed and now generates a placementDecision in the same namespace.
The subscription watches the PlacementDecision changes and deploy the application to the
managed clusters accordingly. The PlacementRule controller needs to be granted access to the
PlacementDecision resource.

(cherry picked from commit 8bc39e1)
(cherry picked from commit 92482e4)
@openshift-ci
Copy link

openshift-ci bot commented Apr 15, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ShyamsundarR

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link

openshift-ci bot commented Apr 15, 2022

@ShyamsundarR: This pull request references Bugzilla bug 2074510, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (ODF 4.10.1) matches configured target release for branch (ODF 4.10.1)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @keesturam

In response to this:

Bug 2074510: Add RBAC role for PlacementDecision resource

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link

openshift-ci bot commented Apr 15, 2022

@openshift-ci[bot]: GitHub didn't allow me to request PR reviews from the following users: keesturam.

Note that only red-hat-storage members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

@ShyamsundarR: This pull request references Bugzilla bug 2074510, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (ODF 4.10.1) matches configured target release for branch (ODF 4.10.1)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @keesturam

In response to this:

Bug 2074510: Add RBAC role for PlacementDecision resource

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ShyamsundarR ShyamsundarR merged commit cb1ef3d into red-hat-storage:release-4.10 Apr 15, 2022
@ShyamsundarR ShyamsundarR deleted the bz2074510 branch April 15, 2022 14:18
@openshift-ci
Copy link

openshift-ci bot commented Apr 15, 2022

@ShyamsundarR: All pull requests linked via external trackers have merged:

Bugzilla bug 2074510 has been moved to the MODIFIED state.

In response to this:

Bug 2074510: Add RBAC role for PlacementDecision resource

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants