Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add disconnected mode support for DR operators #92

Merged

Conversation

ShyamsundarR
Copy link

By adding the required annotation as in the commit.

Signed-off-by: Shyamsundar Ranganathan srangana@redhat.com

By adding the required annotation as in the commit.

Signed-off-by: Shyamsundar Ranganathan <srangana@redhat.com>
@ShyamsundarR
Copy link
Author

The downstrem builds adds the required 'relatedImages' to the CSV, hence that is currently taken care of.

What is not clear is if volsync as build and published by ACM contains the required annotation as well. As Ramen auto installs volsync on the managed clusters. Need to ensure the same for completion.

@raghavendra-talur @umangachapagain PTAL

@umangachapagain
Copy link

The downstrem builds adds the required 'relatedImages' to the CSV, hence that is currently taken care of.

What is not clear is if volsync as build and published by ACM contains the required annotation as well. As Ramen auto installs volsync on the managed clusters. Need to ensure the same for completion.

@raghavendra-talur @umangachapagain PTAL

If volsync is auto installed, we need to make sure RelatedImages points to the right volsync image in builds. If you can point me to where/how this happens I can take a look and suggest a fix.

@umangachapagain
Copy link

Screenshot from 2023-02-07 20-27-59

VolSync already supports disconnected mode.
Also, Ramen doesn't directly reference VolSync image, instead it uses ACM addon resource to deploy it. So, nothing else needs to be done for volsync.

@openshift-ci
Copy link

openshift-ci bot commented Feb 7, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: raghavendra-talur, ShyamsundarR

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@raghavendra-talur raghavendra-talur merged commit dff26f1 into red-hat-storage:main Feb 7, 2023
5 of 6 checks passed
@ShyamsundarR
Copy link
Author

/cherry-pick release-4.12

@openshift-cherrypick-robot
Copy link
Collaborator

@ShyamsundarR: new pull request created: #94

In response to this:

/cherry-pick release-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ShyamsundarR ShyamsundarR deleted the ocp-disconnected branch March 16, 2023 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
4 participants