Release 1.1 #17
Merged
Release 1.1 #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some log messages indicate when the upgrade checks will be performed. If the Ceph image hasn't changed, the upgrade checks are skipped. The messages were confusing if running a Rook upgrade. Signed-off-by: Travis Nielsen <tnielsen@redhat.com> (cherry picked from commit 87e2b09)
Clarify log message for Ceph upgrades (bp #4360)
We recently discovered a race condition which happens not to update the child CRDs when CR image changes. The race happens under the following sequence: * orchestration onAdd() is called when the operator image restarts or its image updated * the orchestration then goes into processing mon/mgr/osd * during this the cluster CR is updated so onUpdate() is called, however, onAdd() is not done yet for child CRDs (mds, rgw) * onUpdate() runs against the cluster CR and updates the cluster images * by the time the child CRDs reached onUpdate() from their respective ParentClusterChanged() methods, the image is already up to date so we were exiting since our check for updating these resources are based on the cluster image version To fix this, we changed the comparison, but using isUpgrade instead and slightly changed the way isUpgrade operates. So now, isUpgrade is true even if the Ceph version is identical which allows us to verify whether or not the image changed. Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1775624 Signed-off-by: Sébastien Han <seb@redhat.com> (cherry picked from commit db61447)
ceph: fix race condition on crd child update (bp #4403)
openshift-ci-robot
added
the
size/S
leseb
pushed a commit
that referenced
this pull request
Sep 30, 2021
Sync from upstream 1.7 to downstream 4.9
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes:
Which issue is resolved by this Pull Request:
Resolves #
Checklist:
make codegen) has been run to update object specifications, if necessary.