Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1894412: ceph: revert fail if mgr prometheus is not default #173

Merged
merged 1 commit into from Feb 17, 2021

Conversation

leseb
Copy link

@leseb leseb commented Feb 17, 2021

This reverts commit 1ed307c. In
8aaff23 we have introduced the ability
to set a specific monitoring port so the block that fails if the port is
not the default 9283 is not needed anymore.

Signed-off-by: Sébastien Han seb@redhat.com
(cherry picked from commit e99c122)
(cherry picked from commit 3384c3f)

Description of your changes:

Which issue is resolved by this Pull Request:
Resolves #

Checklist:

  • Commit Message Formatting: Commit titles and messages follow guidelines in the developer guide.
  • Skip Tests for Docs: Add the flag for skipping the build if this is only a documentation change. See here for the flag.
  • Skip Unrelated Tests: Add a flag to run tests for a specific storage provider. See test options.
  • Reviewed the developer guide on Submitting a Pull Request
  • Documentation has been updated, if necessary.
  • Unit tests have been added, if necessary.
  • Integration tests have been added, if necessary.
  • Pending release notes updated with breaking and/or notable changes, if necessary.
  • Upgrade from previous release is tested and upgrade user guide is updated, if necessary.
  • Code generation (make codegen) has been run to update object specifications, if necessary.

This reverts commit 1ed307c. In
8aaff23 we have introduced the ability
to set a specific monitoring port so the block that fails if the port is
not the default 9283 is not needed anymore.

Signed-off-by: Sébastien Han <seb@redhat.com>
(cherry picked from commit e99c122)
(cherry picked from commit 3384c3f)
@openshift-ci-robot
Copy link

@leseb: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

ceph: revert fail if mgr prometheus is not default

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: leseb
To complete the pull request process, please assign after the PR has been reviewed.
You can assign the PR to them by writing /assign in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@leseb leseb merged commit 020aec3 into red-hat-storage:release-4.7 Feb 17, 2021
@leseb leseb deleted the bz-1894412-downstream branch February 17, 2021 09:38
@leseb leseb changed the title ceph: revert fail if mgr prometheus is not default Bug 1894412: ceph: revert fail if mgr prometheus is not default Feb 17, 2021
@openshift-ci-robot
Copy link

@leseb: All pull requests linked via external trackers have merged:

Bugzilla bug 1894412 has been moved to the MODIFIED state.

In response to this:

Bug 1894412: ceph: revert fail if mgr prometheus is not default

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants