Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CSI: Ability to disable snapshotter from ceph-csi rbd #19

Merged
merged 1 commit into from Dec 3, 2019
Merged

CSI: Ability to disable snapshotter from ceph-csi rbd #19

merged 1 commit into from Dec 3, 2019

Conversation

leseb
Copy link

@leseb leseb commented Dec 3, 2019

we need to set a ENV CSI_RBD_ENABLE_SNAPSHOTTER
variable to "false" in operator template to disable
deployment of snapshotter sidecar in ceph-csi rbd
provisioner.

Fixes: rook#4401
Signed-off-by: Madhu Rajanna madhupr007@gmail.com
(cherry picked from commit cc418bc)

Description of your changes:

Which issue is resolved by this Pull Request:
Resolves #

Checklist:

  • Reviewed the developer guide on Submitting a Pull Request
  • Documentation has been updated, if necessary.
  • Unit tests have been added, if necessary.
  • Integration tests have been added, if necessary.
  • Pending release notes updated with breaking and/or notable changes, if necessary.
  • Upgrade from previous release is tested and upgrade user guide is updated, if necessary.
  • Code generation (make codegen) has been run to update object specifications, if necessary.
  • Comments have been added or updated based on the standards set in CONTRIBUTING.md
  • Add the flag for skipping the CI if this PR does not require a build. See here for more details.

@Madhu-1 @leseb
CSI: Ability to disable snapshotter from ceph-csi rbd
8718ee6 
we need to set a ENV `CSI_RBD_ENABLE_SNAPSHOTTER`
variable to "false" in operator template to disable
deployment of snapshotter sidecar in ceph-csi rbd
provisioner.

Fixes: rook#4401
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
(cherry picked from commit cc418bc)
@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Dec 3, 2019
@leseb leseb mentioned this pull request Dec 3, 2019
Closed
9 tasks
@Madhu-1
Copy link
Member

Madhu-1 commented Dec 3, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 3, 2019
@leseb leseb merged commit 96d5c35 into ocs-4.2 Dec 3, 2019
@travisn travisn deleted the disable-csi-snap branch December 4, 2019 18:45
leseb added a commit that referenced this pull request Sep 30, 2021
@leseb
Merge pull request #19 from rook/release-1.7
17d4fa2 
Sync the latest from upstream release-1.7 to release-4.9
@openshift-ci openshift-ci bot mentioned this pull request Oct 19, 2021
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Madhu-1 Madhu-1

Labels
lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
3 participants
@leseb @Madhu-1 @openshift-ci-robot