Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 2034361: rgw: add startup probe to RGW pod #320

Merged
merged 1 commit into from Jan 31, 2022

Conversation

BlaineEXE
Copy link

Add a startup probe to the RGW pod. Allow 180 seconds for the RGW to
start responding to its /swift/healthcheck endpoint. Usually the RGW
starts up in less than 30 seconds, but it has observed to start between
60-90 seconds into container start in some instances.

Signed-off-by: Blaine Gardner blaine.gardner@redhat.com

Description of your changes:

Which issue is resolved by this Pull Request:
Resolves #

Checklist:

  • Commit Message Formatting: Commit titles and messages follow guidelines in the developer guide.
  • Skip Tests for Docs: Add the flag for skipping the build if this is only a documentation change. See here for the flag.
  • Skip Unrelated Tests: Add a flag to run tests for a specific storage provider. See test options.
  • Reviewed the developer guide on Submitting a Pull Request
  • Documentation has been updated, if necessary.
  • Unit tests have been added, if necessary.
  • Integration tests have been added, if necessary.
  • Pending release notes updated with breaking and/or notable changes, if necessary.
  • Upgrade from previous release is tested and upgrade user guide is updated, if necessary.
  • Code generation (make codegen) has been run to update object specifications, if necessary.

Add a startup probe to the RGW pod. Allow 180 seconds for the RGW to
start responding to its /swift/healthcheck endpoint. Usually the RGW
starts up in less than 30 seconds, but it has observed to start between
60-90 seconds into container start in some instances.

Signed-off-by: Blaine Gardner <blaine.gardner@redhat.com>
@openshift-ci
Copy link

openshift-ci bot commented Dec 17, 2021

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: BlaineEXE

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

},
InitialDelaySeconds: 10,
PeriodSeconds: 10,
FailureThreshold: 18,
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So the total threshold time is 180s? And if it still didn't pass the probe the pod will be restarted, right?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct.

@BlaineEXE BlaineEXE changed the title [BZ 2032404] rgw: add startup probe to RGW pod [BZ 2034361] rgw: add startup probe to RGW pod Dec 20, 2021
@travisn travisn merged commit 4e844be into release-4.9 Jan 31, 2022
@travisn travisn deleted the startup-probe-to-ocs-4.9 branch January 31, 2022 16:32
@travisn travisn changed the title [BZ 2034361] rgw: add startup probe to RGW pod Bug 2034361: rgw: add startup probe to RGW pod Jan 31, 2022
@openshift-ci
Copy link

openshift-ci bot commented Jan 31, 2022

@BlaineEXE: Bugzilla bug 2034361 is in an unrecognized state (MODIFIED) and will not be moved to the MODIFIED state.

In response to this:

Bug 2034361: rgw: add startup probe to RGW pod

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants