Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 2069314: csi: make storage class updated with csi-users in external cluster #386

Merged

Conversation

parth-gr
Copy link

@parth-gr parth-gr commented Jun 8, 2022

Description of your changes:

For using restricted auth users we need to update the
restricted users in the Storage class, so updating
it in the json output for external cluster

Signed-off-by: parth-gr paarora@redhat.com

Which issue is resolved by this Pull Request:
Resolves #

Checklist:

  • Commit Message Formatting: Commit titles and messages follow guidelines in the developer guide.
  • Skip Tests for Docs: Add the flag for skipping the build if this is only a documentation change. See here for the flag.
  • Skip Unrelated Tests: Add a flag to run tests for a specific storage provider. See test options.
  • Reviewed the developer guide on Submitting a Pull Request
  • Documentation has been updated, if necessary.
  • Unit tests have been added, if necessary.
  • Integration tests have been added, if necessary.
  • Pending release notes updated with breaking and/or notable changes, if necessary.
  • Upgrade from previous release is tested and upgrade user guide is updated, if necessary.
  • Code generation (make codegen) has been run to update object specifications, if necessary.

@parth-gr
Copy link
Author

parth-gr commented Jun 8, 2022

@travisn
Copy link

travisn commented Jun 8, 2022

Shall we also backport this on top of the black formatting changes from rook#10399 so we don't have merge conflicts in the future backports?

@parth-gr
Copy link
Author

parth-gr commented Jun 8, 2022

/do-not-merge for a while

@parth-gr
Copy link
Author

parth-gr commented Jun 8, 2022

Shall we also backport this on top of the black formatting changes from rook#10399 so we don't have merge conflicts in the future backports?

Okay yes, checking with Subham

@subhamkrai
Copy link

subhamkrai commented Jun 8, 2022

Shall we also backport this on top of the black formatting changes from rook#10399 so we don't have merge conflicts in the future backports?

can we bp black changes to 4.11 without bz?

@subhamkrai
Copy link

but agree to merge black changes will resolve lot of merge conflicts, in any upcoming prs too

@agarwal-mudit agarwal-mudit changed the title Bug 2069314 : csi: make storage class updated with csi-users in external cluster Bug 2069314: csi: make storage class updated with csi-users in external cluster Jun 9, 2022
@openshift-ci openshift-ci bot added the bugzilla/severity-unspecified Referenced Bugzilla bug's severity is unspecified for the PR. label Jun 9, 2022
@openshift-ci
Copy link

openshift-ci bot commented Jun 9, 2022

@parth-gr: This pull request references Bugzilla bug 2069314, which is invalid:

  • expected the bug to be in one of the following states: NEW, ASSIGNED, ON_DEV, POST, POST, but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 2069314: csi: make storage class updated with csi-users in external cluster

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Jun 9, 2022
@agarwal-mudit
Copy link
Member

@subhamkrai Lets raise a BZ, its just formatting changes, I can ask QE to ack it based on regression.
/bugzilla refresh
/hold

@openshift-ci openshift-ci bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/severity-unspecified Referenced Bugzilla bug's severity is unspecified for the PR. labels Jun 9, 2022
@openshift-ci
Copy link

openshift-ci bot commented Jun 9, 2022

@agarwal-mudit: This pull request references Bugzilla bug 2069314, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

2 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @vavuthu

In response to this:

@subhamkrai Lets raise a BZ, its just formatting changes, I can ask QE to ack it based on regression.
/bugzilla refresh
/hold

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Jun 9, 2022
@openshift-ci
Copy link

openshift-ci bot commented Jun 9, 2022

@openshift-ci[bot]: GitHub didn't allow me to request PR reviews from the following users: vavuthu.

Note that only red-hat-storage members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

@agarwal-mudit: This pull request references Bugzilla bug 2069314, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

2 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @vavuthu

In response to this:

@subhamkrai Lets raise a BZ, its just formatting changes, I can ask QE to ack it based on regression.
/bugzilla refresh
/hold

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@subhamkrai
Copy link

@subhamkrai Lets raise a BZ, its just formatting changes, I can ask QE to ack it based on regression. /bugzilla refresh /hold

Thanks @agarwal-mudit, I'll raise the bz and create the BP pr

@openshift-ci openshift-ci bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 9, 2022
remove the restriction of per rados namespace as
there can be multiple namespaces and the csi-users
can only have 1 type in a storage class

Signed-off-by: parth-gr <paarora@redhat.com>
(cherry picked from commit dcba689)
(cherry picked from commit 5ac9624)
For using restricted auth users we need to update the
restricted users in the Storage class, so updating
it in the json output for external cluster

Signed-off-by: parth-gr <paarora@redhat.com>
(cherry picked from commit b7c165b)
Signed-off-by: parth-gr <paarora@redhat.com>
(cherry picked from commit 82cdc5b)
@openshift-ci openshift-ci bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 13, 2022
@parth-gr
Copy link
Author

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 13, 2022
Copy link
Member

@agarwal-mudit agarwal-mudit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 13, 2022
@openshift-ci
Copy link

openshift-ci bot commented Jun 13, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: agarwal-mudit, parth-gr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 13, 2022
@openshift-ci openshift-ci bot merged commit 8905798 into red-hat-storage:release-4.11 Jun 13, 2022
43 checks passed
@openshift-ci
Copy link

openshift-ci bot commented Jun 13, 2022

@parth-gr: All pull requests linked via external trackers have merged:

Bugzilla bug 2069314 has been moved to the MODIFIED state.

In response to this:

Bug 2069314: csi: make storage class updated with csi-users in external cluster

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
4 participants