New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 2069314: csi: make storage class updated with csi-users in external cluster #386
Bug 2069314: csi: make storage class updated with csi-users in external cluster #386
Conversation
5497910
to
8b7599f
Compare
|
Shall we also backport this on top of the |
|
/do-not-merge for a while |
Okay yes, checking with Subham |
can we bp |
|
but agree to merge black changes will resolve lot of merge conflicts, in any upcoming prs too |
|
@parth-gr: This pull request references Bugzilla bug 2069314, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@subhamkrai Lets raise a BZ, its just formatting changes, I can ask QE to ack it based on regression. |
|
@agarwal-mudit: This pull request references Bugzilla bug 2069314, which is valid. The bug has been updated to refer to the pull request using the external bug tracker. 2 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@openshift-ci[bot]: GitHub didn't allow me to request PR reviews from the following users: vavuthu. Note that only red-hat-storage members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Thanks @agarwal-mudit, I'll raise the bz and create the BP pr |
For using restricted auth users we need to update the restricted users in the Storage class, so updating it in the json output for external cluster Signed-off-by: parth-gr <paarora@redhat.com> (cherry picked from commit b7c165b) Signed-off-by: parth-gr <paarora@redhat.com> (cherry picked from commit 82cdc5b)
8b7599f
to
1d54fb5
Compare
|
/unhold |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: agarwal-mudit, parth-gr The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
8905798
into
red-hat-storage:release-4.11
|
@parth-gr: All pull requests linked via external trackers have merged: Bugzilla bug 2069314 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Description of your changes:
For using restricted auth users we need to update the
restricted users in the Storage class, so updating
it in the json output for external cluster
Signed-off-by: parth-gr paarora@redhat.com
Which issue is resolved by this Pull Request:
Resolves #
Checklist:
make codegen) has been run to update object specifications, if necessary.