New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 2167304: security: run the crash collector as ceph user #447
Bug 2167304: security: run the crash collector as ceph user #447
Conversation
The crash collector does not have the command line arguments to run as ceph user id 167, so we set the security context to run as the ceph user in the main crash collector container. Signed-off-by: Travis Nielsen <tnielsen@redhat.com> (cherry picked from commit df6d7af) Signed-off-by: subhamkrai <srai@redhat.com>
626e8ad
to
a5b434e
Compare
|
Linters/pylint ci error is fixed in upstream versions |
Please also cherry-pick the fix into this PR for rook#11606 so we can get a clean linter. |
The latest python black stable release started flagging a newline between a function `def` and the function body. Remove said newline. Signed-off-by: Blaine Gardner <blaine.gardner@redhat.com> (cherry picked from commit 19fb386)
done |
|
@travisn ready to go in? |
|
What BZ is this for? We need |
|
@subhamkrai: This pull request references Bugzilla bug 2167304, which is valid. 2 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@openshift-ci[bot]: GitHub didn't allow me to request PR reviews from the following users: nehaberry. Note that only red-hat-storage members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
sorry, Travis I missed the ping. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: subhamkrai, travisn The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@subhamkrai: All pull requests linked via external trackers have merged: Bugzilla bug 2167304 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
The crash collector does not have the command line arguments to run as ceph user id 167, so we set the security context to run as the ceph user in the main crash collector container.
Signed-off-by: Travis Nielsen tnielsen@redhat.com
(cherry picked from commit df6d7af)
Description of your changes:
Which issue is resolved by this Pull Request:
Resolves #
Checklist:
skip-cion the PR.