Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.10] Bug 2171963: core: Remove unnecessary env vars from pod specs #455

Merged
merged 3 commits into from Mar 31, 2023
Merged

[release-4.10] Bug 2171963: core: Remove unnecessary env vars from pod specs #455

merged 3 commits into from Mar 31, 2023

Conversation

travisn
Copy link

@travisn travisn commented Mar 16, 2023

Description of your changes:
This is a backport of #436 and #441.

Which issue is resolved by this Pull Request:
Resolves #https://bugzilla.redhat.com/show_bug.cgi?id=2171963

Checklist:

  • Commit Message Formatting: Commit titles and messages follow guidelines in the developer guide).
  • Skip Tests for Docs: If this is only a documentation change, add the label skip-ci on the PR.
  • Reviewed the developer guide on Submitting a Pull Request
  • Pending release notes updated with breaking and/or notable changes for the next minor release.
  • Documentation has been updated, if necessary.
  • Unit tests have been added, if necessary.
  • Integration tests have been added, if necessary.

@openshift-ci openshift-ci bot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Mar 16, 2023
@openshift-ci
Copy link

openshift-ci bot commented Mar 16, 2023

@travisn: This pull request references Bugzilla bug 2171963, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

2 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @nehaberry

In response to this:

[release-4.10] Bug 2171963: core: Remove unnecessary env vars from pod specs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link

openshift-ci bot commented Mar 16, 2023

@openshift-ci[bot]: GitHub didn't allow me to request PR reviews from the following users: nehaberry.

Note that only red-hat-storage members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

@travisn: This pull request references Bugzilla bug 2171963, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

2 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @nehaberry

In response to this:

[release-4.10] Bug 2171963: core: Remove unnecessary env vars from pod specs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@travisn travisn force-pushed the backport-env-vars branch 2 times, most recently from e668719 to 5502b74 Compare March 28, 2023 20:53
@travisn
core: remove unnecessary env vars from pod specs
673c331 
The fsid, username, and user secrets were from legacy and no
longer needed on the osd daemon or mon pods. This removes the
unnecessary env vars from the pod specs.

Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
(cherry picked from commit 33e824a)
(cherry picked from commit d17b663)
@travisn
core: read mon secret from file instead of env var
95980b9 
Environment variables are not recommended for secrets in pods since
they can be easily leaked if the environemnt variables are logged.
By mounting the mon secret as a file, the mgr and osd prepare pods
can read the mon secret from a file for better security.

Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
(cherry picked from commit 4033351)
(cherry picked from commit e2ba8a8)
@travisn
manifest: toolbox and jobs mount secret volume
6e296df 
The toolbox, toolbox job, and osd prepare jobs need to mount the
ceph admin keyring as a file instead of using an env var.
The toolbox script will still allow setting of the env var
for backward compatibility, though all the examples are now
updated to use the keyring as a file.

Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
(cherry picked from commit 4f77664)
(cherry picked from commit 0c2d06c)
@travisn
Copy link
Author

travisn commented Mar 31, 2023

Merging despite the known CI issues that already exist in the 4.10 branch

@travisn
Copy link
Author

travisn commented Mar 31, 2023

/lgtm
/approve

@openshift-ci
Copy link

openshift-ci bot commented Mar 31, 2023

@travisn: you cannot LGTM your own PR.

In response to this:

/lgtm
/approve

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link

openshift-ci bot commented Mar 31, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: travisn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@travisn travisn merged commit abc959d into red-hat-storage:release-4.10 Mar 31, 2023
21 of 35 checks passed
@travisn travisn deleted the backport-env-vars branch March 31, 2023 19:54
@openshift-ci
Copy link

openshift-ci bot commented Mar 31, 2023

@travisn: All pull requests linked via external trackers have merged:

Bugzilla bug 2171963 has been moved to the MODIFIED state.

In response to this:

[release-4.10] Bug 2171963: core: Remove unnecessary env vars from pod specs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting.
Projects
None yet
Milestone
No milestone
1 participant
@travisn