New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 2192824: external: fixed validate_rgw_endpoint pool validation #483
Bug 2192824: external: fixed validate_rgw_endpoint pool validation #483
Conversation
|
@parth-gr: No Bugzilla bug is referenced in the title of this pull request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
05b9fa9
to
9f2276e
Compare
|
@parth-gr: No Bugzilla bug is referenced in the title of this pull request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@parth-gr: This pull request references Bugzilla bug 2192824, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
c6decad
to
d94c361
Compare
the check validate_rgw_multisite was always checking for realm updated it to check the specific config fixed validate_rgw_endpoint pool validation added missing realm zonegroup and zone while interacting with user resources Co-authored-by: Sergio Pérez Fernández <sergioperez794@gmail.com> Signed-off-by: parth-gr <paarora@redhat.com> (cherry picked from commit c50c308)
d94c361
to
306583a
Compare
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: parth-gr, travisn The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/bugzilla refresh |
|
@travisn: This pull request references Bugzilla bug 2192824, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@openshift-ci[bot]: GitHub didn't allow me to request PR reviews from the following users: nehaberry. Note that only red-hat-storage members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@parth-gr: All pull requests linked via external trackers have merged: Bugzilla bug 2192824 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Description of your changes:
external: fixed validate_rgw_endpoint pool validation
The function pool_exists seems to only accept a string, but not a List, as it is given in validate_rgw_endpoint.
The change iterates calling pool_exists one by one over the list of pools given in validate_rgw_endpoint. This change made it possible to us to connect our RGW to OCP via Rook.
Add missing usage of realm, zone and zonegroup while retrieving user info and adding user capabilities.
Which issue is resolved by this Pull Request:
Resolves #
Checklist:
skip-cion the PR.