Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 2192823: rgw: fixed validate_rgw_endpoint pool validation #485

Merged
merged 2 commits into from May 8, 2023
Merged

Bug 2192823: rgw: fixed validate_rgw_endpoint pool validation #485

merged 2 commits into from May 8, 2023

Conversation

parth-gr
Copy link

Signed-off-by: Sergio Pérez Fernández sergioperez794@gmail.com
(cherry picked from commit a1e604d)

Description of your changes:

Which issue is resolved by this Pull Request:
Resolves #

Checklist:

  • Commit Message Formatting: Commit titles and messages follow guidelines in the developer guide).
  • Skip Tests for Docs: If this is only a documentation change, add the label skip-ci on the PR.
  • Reviewed the developer guide on Submitting a Pull Request
  • Pending release notes updated with breaking and/or notable changes for the next minor release.
  • Documentation has been updated, if necessary.
  • Unit tests have been added, if necessary.
  • Integration tests have been added, if necessary.

@openshift-ci
Copy link

openshift-ci bot commented Apr 29, 2023

@parth-gr: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

fixed validate_rgw_endpoint pool validation

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@parth-gr parth-gr changed the title fixed validate_rgw_endpoint pool validation rgw: fixed validate_rgw_endpoint pool validation Apr 29, 2023
@openshift-ci
Copy link

openshift-ci bot commented Apr 29, 2023

@parth-gr: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

rgw: fixed validate_rgw_endpoint pool validation

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@parth-gr parth-gr force-pushed the external-multisite-fix-downstream-4.11 branch 3 times, most recently from e1ab3f3 to 9e66a61 Compare May 3, 2023 10:45
@parth-gr parth-gr changed the title rgw: fixed validate_rgw_endpoint pool validation Bug 2192823: rgw: fixed validate_rgw_endpoint pool validation May 3, 2023
@openshift-ci openshift-ci bot added bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels May 3, 2023
@openshift-ci
Copy link

openshift-ci bot commented May 3, 2023

@parth-gr: This pull request references Bugzilla bug 2192823, which is invalid:

  • expected the bug to target the "ODF 4.11.8" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 2192823: rgw: fixed validate_rgw_endpoint pool validation

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@parth-gr
Copy link
Author

parth-gr commented May 3, 2023

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 3, 2023
@parth-gr parth-gr force-pushed the external-multisite-fix-downstream-4.11 branch from 9e66a61 to 47e2af3 Compare May 3, 2023 10:52
@parth-gr
Copy link
Author

parth-gr commented May 3, 2023

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 3, 2023
@parth-gr parth-gr force-pushed the external-multisite-fix-downstream-4.11 branch 4 times, most recently from a073ac4 to f2727bf Compare May 4, 2023 19:35
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 4, 2023
@parth-gr parth-gr force-pushed the external-multisite-fix-downstream-4.11 branch from f2727bf to 84444af Compare May 4, 2023 19:37
@parth-gr
rgw: fix endpoint_dial check for rgw endpoint
9c4ca4b 
the validate rgw endpoint tls cert returns the certificate instead
of returning whether it exist or not,
So updatd the flow how to use it

Closes: rook#11060
Signed-off-by: parth-gr <paarora@redhat.com>
(cherry picked from commit fb7b67c)
@parth-gr parth-gr force-pushed the external-multisite-fix-downstream-4.11 branch from 84444af to 7271558 Compare May 4, 2023 19:37
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 4, 2023
@parth-gr parth-gr force-pushed the external-multisite-fix-downstream-4.11 branch 3 times, most recently from 40f1aac to 557d940 Compare May 8, 2023 13:32
@parth-gr @sergioperez
rgw: fix rgw multisite config checks
cd72dde 
the check validate_rgw_multisite was always checking for realm
updated it to check the specific config

fixed validate_rgw_endpoint pool validation

added missing realm zonegroup and zone while interacting with user resources

Co-authored-by: Sergio Pérez Fernández <sergioperez794@gmail.com>
Signed-off-by: parth-gr <paarora@redhat.com>
(cherry picked from commit c50c308)
Signed-off-by: parth-gr <paarora@redhat.com>
@parth-gr parth-gr force-pushed the external-multisite-fix-downstream-4.11 branch from 557d940 to cd72dde Compare May 8, 2023 13:49
@travisn
Copy link

travisn commented May 8, 2023

/bugzilla refresh

@openshift-ci openshift-ci bot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label May 8, 2023
@travisn
Copy link

travisn commented May 8, 2023

/approve
/lgtm

@openshift-ci
Copy link

openshift-ci bot commented May 8, 2023

@travisn: This pull request references Bugzilla bug 2192823, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (ODF 4.11.8) matches configured target release for branch (ODF 4.11.8)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @nehaberry

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label May 8, 2023
@openshift-ci
Copy link

openshift-ci bot commented May 8, 2023

@openshift-ci[bot]: GitHub didn't allow me to request PR reviews from the following users: nehaberry.

Note that only red-hat-storage members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

@travisn: This pull request references Bugzilla bug 2192823, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (ODF 4.11.8) matches configured target release for branch (ODF 4.11.8)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @nehaberry

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 8, 2023
@openshift-ci
Copy link

openshift-ci bot commented May 8, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: parth-gr, travisn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 8, 2023
@travisn travisn merged commit f2280a2 into red-hat-storage:release-4.11 May 8, 2023
29 of 42 checks passed
@openshift-ci
Copy link

openshift-ci bot commented May 8, 2023

@parth-gr: All pull requests linked via external trackers have merged:

Bugzilla bug 2192823 has been moved to the MODIFIED state.

In response to this:

Bug 2192823: rgw: fixed validate_rgw_endpoint pool validation

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot mentioned this pull request May 17, 2023
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@travisn travisn

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
3 participants
@parth-gr @travisn @openshift-merge-robot