Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 2192875: Enable exporter for downstream 4.13 #487

Merged
merged 2 commits into from May 15, 2023

Conversation

avanthakkar
Copy link

Signed-off-by: avanthakkar avanjohn@gmail.com

Description of your changes:
All regression for ceph-exporter are fixed in downstream Ceph v6.1, so enabling the exporter again.

Which issue is resolved by this Pull Request:
Resolves #

Checklist:

  • Commit Message Formatting: Commit titles and messages follow guidelines in the developer guide).
  • Skip Tests for Docs: If this is only a documentation change, add the label skip-ci on the PR.
  • Reviewed the developer guide on Submitting a Pull Request
  • Pending release notes updated with breaking and/or notable changes for the next minor release.
  • Documentation has been updated, if necessary.
  • Unit tests have been added, if necessary.
  • Integration tests have been added, if necessary.

@openshift-ci openshift-ci bot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels May 3, 2023
@openshift-ci
Copy link

openshift-ci bot commented May 3, 2023

@avanthakkar: This pull request references Bugzilla bug 2192875, which is invalid:

  • expected the bug to target the "ODF 4.13.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 2192875: Enable exporter for downstream 4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@avanthakkar
Copy link
Author

/bugzilla refresh

@openshift-ci
Copy link

openshift-ci bot commented May 3, 2023

@avanthakkar: This pull request references Bugzilla bug 2192875, which is invalid:

  • expected the bug to target the "ODF 4.13.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link

openshift-ci bot commented May 8, 2023

@jmolmo: changing LGTM is restricted to collaborators

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

All regression for ceph-exporter are fixed in downstream Ceph v6.1,
so enabling the exporter again.
Signed-off-by: avanthakkar <avanjohn@gmail.com>
Shorten the termination time for exporter pod before it
gets deleted to avoid crashing of pod.
Signed-off-by: avanthakkar <avanjohn@gmail.com>
(cherry picked from commit 8a8eb86)
Copy link
Member

@jmolmo jmolmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe to enable the exporter , and to shorten the termination time of the exporter pod would be two different prs.

@openshift-ci
Copy link

openshift-ci bot commented May 11, 2023

@jmolmo: changing LGTM is restricted to collaborators

In response to this:

Maybe to enable the exporter , and to shorten the termination time of the exporter pod would be two different prs.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@travisn
Copy link

travisn commented May 11, 2023

Maybe to enable the exporter , and to shorten the termination time of the exporter pod would be two different prs.

Avan and I had discussed the two commits in a single PR, but two separate PRs would have been ok too.

@agarwal-mudit
Copy link
Member

/bugzilla refresh

@openshift-ci openshift-ci bot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels May 15, 2023
@openshift-ci
Copy link

openshift-ci bot commented May 15, 2023

@agarwal-mudit: This pull request references Bugzilla bug 2192875, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (ODF 4.13.0) matches configured target release for branch (ODF 4.13.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (sagrawal@redhat.com), skipping review request.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@travisn
Copy link

travisn commented May 15, 2023

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 15, 2023
@openshift-ci
Copy link

openshift-ci bot commented May 15, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: avanthakkar, jmolmo, travisn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 15, 2023
@travisn travisn merged commit dace484 into red-hat-storage:release-4.13 May 15, 2023
43 of 47 checks passed
@openshift-ci
Copy link

openshift-ci bot commented May 15, 2023

@avanthakkar: All pull requests linked via external trackers have merged:

Bugzilla bug 2192875 has been moved to the MODIFIED state.

In response to this:

Bug 2192875: Enable exporter for downstream 4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
4 participants