New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 2192875: Enable exporter for downstream 4.13 #487
Bug 2192875: Enable exporter for downstream 4.13 #487
Conversation
|
@avanthakkar: This pull request references Bugzilla bug 2192875, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/bugzilla refresh |
|
@avanthakkar: This pull request references Bugzilla bug 2192875, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@jmolmo: changing LGTM is restricted to collaborators In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
All regression for ceph-exporter are fixed in downstream Ceph v6.1, so enabling the exporter again. Signed-off-by: avanthakkar <avanjohn@gmail.com>
Shorten the termination time for exporter pod before it gets deleted to avoid crashing of pod. Signed-off-by: avanthakkar <avanjohn@gmail.com> (cherry picked from commit 8a8eb86)
ed4d3dc
to
ed187b8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe to enable the exporter , and to shorten the termination time of the exporter pod would be two different prs.
|
@jmolmo: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Avan and I had discussed the two commits in a single PR, but two separate PRs would have been ok too. |
|
/bugzilla refresh |
|
@agarwal-mudit: This pull request references Bugzilla bug 2192875, which is valid. 3 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Bugzilla (sagrawal@redhat.com), skipping review request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: avanthakkar, jmolmo, travisn The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@avanthakkar: All pull requests linked via external trackers have merged: Bugzilla bug 2192875 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off-by: avanthakkar avanjohn@gmail.com
Description of your changes:
All regression for ceph-exporter are fixed in downstream Ceph v6.1, so enabling the exporter again.
Which issue is resolved by this Pull Request:
Resolves #
Checklist:
skip-cion the PR.