Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 2192823: external: fix rgw check if no multisite flag is passed #491

Merged

Conversation

parth-gr
Copy link

Description of your changes:

if there is no multisite config pass, it will still checks for the zones and zones group and not able to query anything

Signed-off-by: parth-gr paarora@redhat.com
(cherry picked from commit ec2681f)

Which issue is resolved by this Pull Request:
Resolves #

Checklist:

  • Commit Message Formatting: Commit titles and messages follow guidelines in the developer guide).
  • Skip Tests for Docs: If this is only a documentation change, add the label skip-ci on the PR.
  • Reviewed the developer guide on Submitting a Pull Request
  • Pending release notes updated with breaking and/or notable changes for the next minor release.
  • Documentation has been updated, if necessary.
  • Unit tests have been added, if necessary.
  • Integration tests have been added, if necessary.

@openshift-ci openshift-ci bot added bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels May 16, 2023
@openshift-ci
Copy link

openshift-ci bot commented May 16, 2023

@parth-gr: This pull request references Bugzilla bug 2192823, which is invalid:

  • expected the bug to be in one of the following states: NEW, ASSIGNED, ON_DEV, POST, POST, but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 2192823: external: fix rgw check if no multisite flag is passed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

if there is no multisite config pass, it will still checks for
the zones and zones group and not able to query anything

Signed-off-by: parth-gr <paarora@redhat.com>
(cherry picked from commit ec2681f)
Signed-off-by: parth-gr <paarora@redhat.com>
@parth-gr parth-gr force-pushed the external-multisite-bug--4.11 branch from 3cf03cc to a577b0e Compare May 17, 2023 10:54
@parth-gr
Copy link
Author

/assign @travisn

@travisn
Copy link

travisn commented May 17, 2023

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 17, 2023
@openshift-ci
Copy link

openshift-ci bot commented May 17, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: parth-gr, travisn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 17, 2023
@travisn travisn merged commit 6934e4e into red-hat-storage:release-4.11 May 17, 2023
29 of 42 checks passed
@openshift-ci
Copy link

openshift-ci bot commented May 17, 2023

@parth-gr: All pull requests linked via external trackers have merged:

Bugzilla bug 2192823 has been moved to the MODIFIED state.

In response to this:

Bug 2192823: external: fix rgw check if no multisite flag is passed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
2 participants