BUG 2007202: Update conditions to reflect degraded and resyncing #10
Conversation
The condition updates are when processing as secondary
- Resyncing
- Is false on any errors
- Is false if degraded is false
- Is true, if resync is successful and volume is not
yet "ready" to use
- Degraded
- Is true on errors
- Is true UNTIL resync returns "ready" response
- Is false ONLY when resync returns "ready"
As Degraded moves to false, resyncing will move to
false as well, other than cases where there are
errors, or resync status is not yet determined. Resync
status is, for example, undetermined if we issued a
demote volume request, from markVolAsSecondary.
Resyncing: denotes if resync is active
Degraded: denotes local secondary contents are not
in full sync with remote, and that happens only when
remote is marked Secondary and local is also Secondary
and the final sync is complete.
Hence, Resyncing is false when degraded is false, as
there is no more data to sync.
Completed is always the initial condition to check before
looking at other conditions, to ensure operation was a
success. IOW, Completed being false, currently negates
any value in the other 2 conditions, and should typically
be Resync: false and Degraded: true.
Fixes: csi-addons#101
Signed-off-by: Shyamsundar Ranganathan <srangana@redhat.com>
(cherry picked from commit d33dbd5)
secondary when the VR is marked as secondary the current instance object still contains the status.State as primary not secondary. we need to set the status.State to secondary when the volume is demoted successfully. Signed-off-by: Madhu Rajanna <madhupr007@gmail.com> (cherry picked from commit 597f3f8)
|
@Madhu-1: No Bugzilla bug is referenced in the title of this pull request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Madhu-1
changed the title
|
@Madhu-1: This pull request references Bugzilla bug 2007202, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/assign @agarwal-mudit |
|
@Madhu-1: GitHub didn't allow me to assign the following users: ShyamsundarR. Note that only red-hat-storage members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@ShyamsundarR: changing LGTM is restricted to collaborators In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Madhu-1, ShyamsundarR The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/bugzilla refresh |
|
@agarwal-mudit: This pull request references Bugzilla bug 2007202, which is valid. 3 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Bugzilla (ratamir@redhat.com), skipping review request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@Madhu-1: All pull requests linked via external trackers have merged: Bugzilla bug 2007202 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Backport of csi-addons#113 and csi-addons#116