Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG 2016031: set RequeueAfter to 30 secondary for requeue #11

Merged
merged 2 commits into from Oct 27, 2021

Conversation

Madhu-1
Copy link
Member

@Madhu-1 Madhu-1 commented Oct 27, 2021

this is backporting of csi-addons#123 and csi-addons#124

Setting Requeue time for 30 seconds as the
resync can take time and having default
Requeue exponential backoff time can affect
the RTO time

closes: csi-addons#120

Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
(cherry picked from commit 8c7d3f8)
if the resync failed (marking the image as secondary)
failed, requeue the request for 15 seconds as this can
also increases the recovery time.

Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
(cherry picked from commit 8ed8617)
@openshift-ci
Copy link

openshift-ci bot commented Oct 27, 2021

@Madhu-1: This pull request references Bugzilla bug 2016031, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (ODF 4.9.0) matches configured target release for branch (ODF 4.9.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @prsurve

In response to this:

BUG 2016031: set RequeueAfter to 30 secondary for requeue

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link

openshift-ci bot commented Oct 27, 2021

@openshift-ci[bot]: GitHub didn't allow me to request PR reviews from the following users: prsurve.

Note that only red-hat-storage members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

@Madhu-1: This pull request references Bugzilla bug 2016031, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (ODF 4.9.0) matches configured target release for branch (ODF 4.9.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @prsurve

In response to this:

BUG 2016031: set RequeueAfter to 30 secondary for requeue

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Madhu-1
Copy link
Member Author

Madhu-1 commented Oct 27, 2021

/assign @agarwal-mudit

Copy link
Member

@agarwal-mudit agarwal-mudit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Oct 27, 2021
@openshift-ci
Copy link

openshift-ci bot commented Oct 27, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: agarwal-mudit, Madhu-1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 82f68db into red-hat-storage:release-4.9 Oct 27, 2021
@openshift-ci
Copy link

openshift-ci bot commented Oct 27, 2021

@Madhu-1: All pull requests linked via external trackers have merged:

Bugzilla bug 2016031 has been moved to the MODIFIED state.

In response to this:

BUG 2016031: set RequeueAfter to 30 secondary for requeue

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants