New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BUG 2016031: set RequeueAfter to 30 secondary for requeue #11
BUG 2016031: set RequeueAfter to 30 secondary for requeue #11
Conversation
Setting Requeue time for 30 seconds as the resync can take time and having default Requeue exponential backoff time can affect the RTO time closes: csi-addons#120 Signed-off-by: Madhu Rajanna <madhupr007@gmail.com> (cherry picked from commit 8c7d3f8)
if the resync failed (marking the image as secondary) failed, requeue the request for 15 seconds as this can also increases the recovery time. Signed-off-by: Madhu Rajanna <madhupr007@gmail.com> (cherry picked from commit 8ed8617)
|
@Madhu-1: This pull request references Bugzilla bug 2016031, which is valid. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@openshift-ci[bot]: GitHub didn't allow me to request PR reviews from the following users: prsurve. Note that only red-hat-storage members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/assign @agarwal-mudit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: agarwal-mudit, Madhu-1 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@Madhu-1: All pull requests linked via external trackers have merged: Bugzilla bug 2016031 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
this is backporting of csi-addons#123 and csi-addons#124