Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
layered base fixes & tests #3683
Wow it got the tests passed ☺
Basically this was meant to fix 3 things:
Brief summary of changes and findings:
Everything else is either minor refactoring or obvious minor fixes.
Then the second part.
View subsystem is already very complicated. For example, it's almost impossible to tell what function will draw the background or text just by following the code. It is in very bad need of refactoring. However we don't really have tests for it, so any attempt will likely ruin what's already working. Moreover I've watched it regress not a single time. Sooner or later we are bound to start testing it, so why not today? ☻
I've included 300+ tests for the changes this PR brings about, that capture the output and analyze if what was drawn is what was requested. Tested and working on live W7 and W8.
My observation of PrintWindow on W8 is that it captures the real visible state of the window, so:
Of course all these effects can be successfully dealt with.
W10 volunteers are welcome to give it a try: build the console from this branch and run
I decided to include this test into
Let me know if there is a better way. For the time being this makes