Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Unite colors in right order #3698

Merged
merged 1 commit into from Jan 2, 2019

Conversation

Projects
None yet
3 participants
@toomasv
Copy link
Contributor

toomasv commented Jan 2, 2019

Color-tuple should stay just after range when uniting styles, as explained by @qtxie in #3691

Also: Count colors in path (may be multiple colors in path, last is rendered), fixed new-line for close-colors.

FIX: Unite colors in right order
Also: Count colors in path, fixed new-line for `close-colors`
@greggirwin

This comment has been minimized.

Copy link
Contributor

greggirwin commented Jan 2, 2019

Thanks for your recent fixes in this area @toomasv. Many are not simple.

@greggirwin greggirwin merged commit 43d8ac6 into red:master Jan 2, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@qtxie

This comment has been minimized.

Copy link
Contributor

qtxie commented Jan 3, 2019

Perfect! Kodus to you. @toomasv 👍

@toomasv

This comment has been minimized.

Copy link
Contributor Author

toomasv commented Jan 3, 2019

Thanks @greggirwin and @qtxie !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.