Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gtk for red-0.6.4 #3718

Merged
merged 5 commits into from Jan 11, 2019

Conversation

Projects
None yet
2 participants
@rcqls
Copy link

rcqls commented Jan 8, 2019

Updated code to be used at least with red-0.6.4

@qtxie
Copy link
Contributor

qtxie left a comment

Overall it's good except rule.red. If it's a debug leftover, please remove it. Or just provide empty functions in it.

@@ -157,6 +157,7 @@ write %build/bin/sources.r set-cache [
%win32.reds
%COM.reds
%image-gdiplus.reds
%image-gdk.reds

This comment has been minimized.

@qtxie

qtxie Jan 10, 2019

Contributor

This file is included twice.

This comment has been minimized.

@rcqls

rcqls Jan 10, 2019

Author

For the rules.red file I 'll only keep the Cancel-OK rule.

@@ -790,18 +794,18 @@ system/view/platform: context [
progress: 21
]
]
; GTK Backend (similar to macOS from now)
Linux [
extend system/view/metrics/def-heights [

This comment has been minimized.

@qtxie

qtxie Jan 10, 2019

Contributor

Is there a reason to change those def-heights to simliar to macOS? IIRC, those values are chosen specific for GTK3.

This comment has been minimized.

@rcqls

rcqls Jan 10, 2019

Author

This is here as a reminder to fix the values later. You know that this branch is far from being stable.

This comment has been minimized.

@qtxie

qtxie Jan 11, 2019

Contributor

But those values are chosen on purpose, not arbitrary. Does the new values gives better results?

This comment has been minimized.

@rcqls

rcqls Jan 11, 2019

Author

Apparently, no significant effect. I then removed this setting

@qtxie qtxie merged commit 8c1bad4 into red:GTK Jan 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.