Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A preliminary useable version of red/GTK #3928

Merged
merged 1 commit into from Jul 1, 2019

Conversation

Projects
None yet
3 participants
@rcqls
Copy link

commented Jun 27, 2019

To merge more easily the development of the branch rcqls/red:GTK-dev, I simply pulled the red/red:GTK and copied the reds files of the rcqls/red:GTK-dev. As a consequence, I am loosing the git history (of the rcqls/red:GTK-dev) but in fact this is done on purpose since this history was not really interesting. Hope this PR could be a good starting point for people willing to contribute in the red/red:GTK.
Also in this PR, I intentionally remove the camera stuff that I will add soon when more complete. Some ugly DEBUG comments are still there but could be removed soon when the community would think that this stuff is more and more stable.

@qtxie

This comment has been minimized.

Copy link
Contributor

commented Jun 27, 2019

Thanks for the big PR. The code looks good. 👍

Would you please provide us a list of features implemented in this PR?
I saw that many of the DRAW commands were implemented, but some of them are not completed. e.g. draw-curve function.

@rcqls

This comment has been minimized.

Copy link
Author

commented Jun 27, 2019

@qtxie Normally everything is mostly done except:

  • draw shape dialect that's need to be done
  • camera is missing but I have already prepared a first proposal to PR soon that unfortunately requires more dependencies that I need to prepare as an installation bash script for main linux distributions.
  • rich-text is only a first proposal but needs enhancement to be completed
  • para is not completed too

To evaluate this PR, I usually try scripts from code, community repos from red Github account. Also lot of codes mostly from @toomasv and also other contributors are tested too.
As you guess, not everything is perfect but, as @rebolek very often says in the Gitter/red-GTK room, it is useable and it was indeed my primary goal.

BTW, since some changes in red/system were introduced, some adjustments were necessary. I hope that port update would be easily merged by the red team.

@rebolek

This comment has been minimized.

Copy link
Contributor

commented Jun 28, 2019

@rcqls just a note, if you want to "loose" the history, proper workflow in Git is to rebase (or squash) your commits. It's actually very easy, there are some tutorials and if you are interested how to do it, just contact me over Gitter.

@dockimbel dockimbel requested a review from qtxie Jun 28, 2019

@qtxie

qtxie approved these changes Jun 30, 2019

@qtxie qtxie merged commit 172f5d7 into red:GTK Jul 1, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.