Support more OpenWRT TRX files by making fewer assumptions about the partitions #216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
EdwardLarson
commented
Feb 9, 2023
|
LGTM! (though this is technically my PR, none of the code is mine, so I count my review as a proper review) |
whyitfor
approved these changes
Feb 10, 2023
marczalik
pushed a commit
to marczalik/ofrak
that referenced
this pull request
Feb 14, 2023
…partitions (redballoonsecurity#216) * add explicit checks for rootfs_offset * create resource from empty data instead of None * fix second instance of None vs empty array * change empty resources to byte arrays * appease The Linter * add openwrt null rootfs testcase * openwrt updates * changed tests to match new openwrt functionality * Update OpenWRT modifier and packer to use new format * Address black issues in lzma.py * add the changelog * Fix typos * fix typo --------- Co-authored-by: Rylan <rylan.oconnell@twosixtech.com> Co-authored-by: SamL98 <lerner98@gmail.com> Co-authored-by: Edward Larson <edward@redballoonsecurity.com> Co-authored-by: Wyatt <53830972+whyitfor@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One sentence summary of this PR (This should go in the CHANGELOG!)
Support more OpenWRT TRX files by making fewer assumptions about the partitions
Link to Related Issue(s)
#153
(#187, #161 previous PR)
Please describe the changes in your request.
The OpenWRT documentation here does not describe the TRX file format in the general case. The code here shows how TRX files are actually created: up to three images (or partitions), possibly padded, are added to the file. These partitions do not necessarily correspond to loader, kernel, etc. described in the wiki or are not necessarily in that order. Therefore the TRX packer/unpacker needs to be much more general than it previously was.
Anyone you think should look at this, specifically?
@whyitfor @SamL98