Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to docker logging and routeings #90

Merged
merged 1 commit into from Sep 9, 2019

Conversation

@butlerx
Copy link
Contributor

commented Apr 14, 2018

add traefik
add procedures for adding a docker service
remove legacy
add tick header
fix formatting

@@ -14,8 +14,13 @@

## Services

**This is a docker host all services should run in a container** see
[docs](../procedures/docker-serivce)

This comment has been minimized.

Copy link
@VoyTechnology

VoyTechnology Apr 14, 2018

Contributor

docker-service?


All Docker files will be `/etc/docker-compose/services/$SERVICE_NAME`. Config
files will be in either in the folder with the docker files or mapped to the
traditional location such as `/ect/$SERIVCE_NAME` or `/var/lib/$SERVICE_NAME`

This comment has been minimized.

Copy link
@VoyTechnology

VoyTechnology Apr 14, 2018

Contributor

ect -> etc

@butlerx butlerx force-pushed the butlerx:update/dcoker branch from 30857bf to 76c8643 Apr 14, 2018
Copy link
Collaborator

left a comment

Looks good. I'm just not sure about keeping copies of the docker-compose and config files in the docs. It seems like an unnecessary duplication of data, and more work for admins updating those files to deal with. I think pointing to their location on disk would be suffice.

audit.enabled: true
```

docker-compose.yml

This comment has been minimized.

Copy link
@m1cr0man

m1cr0man Feb 26, 2019

Collaborator

I don't think it's a great idea to put the configs in the docs. Simply pointing an admin to their location on a server would be sufficient and it means we aren't counting on admins to update 2 places.

This comment has been minimized.

Copy link
@butlerx

butlerx Feb 27, 2019

Author Contributor

this was placed here more of an incase the server is lost.

what is actually needed is an eternal repo of the docker services compose files.

This comment has been minimized.

Copy link
@theycallmemac

theycallmemac Sep 6, 2019

Member

@butlerx docker-compose configs on Redbrick have been made redundant privately on Github. If you remove configs I'd be happy to merge!

This comment has been minimized.

Copy link
@butlerx

butlerx Sep 6, 2019

Author Contributor

this pr is outdated now since @m1cr0man deprecated es. i imagine the docker service and traefik info is partially right. @m1cr0man shall we remove the es part, or merge and remove with tick stack info?

This comment has been minimized.

Copy link
@theycallmemac

theycallmemac Sep 6, 2019

Member

I would say remove the es part and then we can further add the tick info.

@butlerx butlerx dismissed stale reviews from m1cr0man and theycallmemac via 80e79af Sep 6, 2019
@butlerx butlerx force-pushed the butlerx:update/dcoker branch from 5d5b70c to 80e79af Sep 6, 2019
add traefik
add procedures for adding a docker serverice
add requirements for volumes
remove configs
remove legacy docs
@butlerx butlerx force-pushed the butlerx:update/dcoker branch from 80e79af to b376194 Sep 7, 2019
@theycallmemac

This comment has been minimized.

Copy link
Member

commented Sep 7, 2019

Any reason why a lot of the docs under legacy have been deleted in this PR? @butlerx

@butlerx

This comment has been minimized.

Copy link
Contributor Author

commented Sep 7, 2019

they were meant to have been deleted a while ago. in favour of using git history. we kept them around to ensure everything that was needed was pulled out before deleting. with rb-ldap changes being merged in im confident this pr encompasses the final clean up of the repo and update to state of my last interaction with the stack.

@theycallmemac

This comment has been minimized.

Copy link
Member

commented Sep 9, 2019

In this case I'd say remove what you have on ES and we can add the tick information in a separate PR.

@m1cr0man

This comment has been minimized.

Copy link
Collaborator

commented Sep 9, 2019

Spoke to Cian about this IRL. I think it makes sense to merge this as-is and when I write the docs on TICK I will deprecate the old monitoring info.

@m1cr0man

This comment has been minimized.

Copy link
Collaborator

commented Sep 9, 2019

Sorry...I wrote that and forgot part of my point. It's sensible to keep for historical records of the infra.

@theycallmemac

This comment has been minimized.

Copy link
Member

commented Sep 9, 2019

That is a good point. To have an account of past infra is important. We happy to merge this then?

@m1cr0man

This comment has been minimized.

Copy link
Collaborator

commented Sep 9, 2019

Go for it 👍

@theycallmemac theycallmemac merged commit 91e2ae6 into redbrick:master Sep 9, 2019
1 check failed
1 check failed
ci/circleci Your tests failed on CircleCI
Details
@butlerx butlerx deleted the butlerx:update/dcoker branch Sep 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.