This repository has been archived by the owner. It is now read-only.
Permalink
Switch branches/tags
Nothing to show
Commits on Oct 16, 2017
  1. Update README for archival

    bsimpson63 committed Oct 14, 2017
  2. Remove CONTRIBUTING.md

    bsimpson63 committed Oct 14, 2017
    The repository is archived and not accepting contributions.
  3. ApiDocs: Don't link to code

    bsimpson63 committed Oct 14, 2017
    The docs are generated from the production code, but the links are to the
    deprecated opensource repository (github.com/reddit/reddit), so the
    links and line references are wrong.
  4. Fix https config

    bsimpson63 committed Oct 12, 2017
  5. Fix expando icons

    bsimpson63 committed Oct 12, 2017
Commits on Oct 12, 2017
Commits on Mar 9, 2017
  1. setup_cassandra: Increase the per-thread stack size

    bsimpson63 committed Mar 1, 2017
    This used to be set to 256k in cassandra version 1.2.19, but we
    recently downgraded to version 1.2.11 where it's set too low.
  2. reddit.sh: Install plugins before attempting first startup

    bsimpson63 committed Feb 28, 2017
    This lets Cassandra CFs in the plugins get created at the same time,
    avoiding some weird conflict or race condition.
Commits on Feb 21, 2017
  1. Randomize scores of all top level comments for shuffle sort

    bsimpson63 committed Feb 20, 2017
    This will ensure that all top level comments are considered for
    display. It also makes it more clear that the sorting of child
    comments is uneffected.
Commits on Jan 19, 2017
  1. tracing: Add traces for Cassandra

    bsimpson63 committed Jan 13, 2017
Commits on Jan 12, 2017
  1. search: Disable faceting

    bsimpson63 committed Jan 11, 2017
    Faceting returns counts of query matches per subreddit name so we can
    show the user all the subreddits that contain links for their query.
    This ends up returning many unpopular subreddits, which when looked up
    by name are often missing from cache and result in a postgres query. This
    is bad for performance, and the feature is not popular with users so it is
    safe to remove.
Commits on Dec 14, 2016
  1. MultiApiController: fix on_validation_error() to set code

    bsimpson63 committed Dec 14, 2016
    Some errors don't have a code associated with them so we need to
    supply a default value to abort_with_error. This fixes the
    USER_DOESNT_EXIST errors that are causing exceptions.
Commits on Dec 8, 2016
  1. Use stale subreddit lookup for saved subreddits

    bsimpson63 committed Dec 8, 2016
Commits on Nov 22, 2016
  1. StripeController: Add noop 'review.opened' event

    bsimpson63 committed Nov 22, 2016
Commits on Nov 14, 2016
  1. Process updates in non-fastlane queue when a link is fastlaned

    bsimpson63 committed Aug 9, 2016
    Previously the messages in the non-fastlane queue were dropped so some
    older comments would not be added to the CommentTree. There may be some
    lock contention with multiple queue consumers processing updates for the
    fastlaned links, but it shouldn't last very long.
  2. Remove live config "precomputed_comment_sort_read_chance"

    bsimpson63 committed Aug 8, 2016
    This was used to gradually ramp up reads of the precomputed comment
    orders. We've been running for a while with this set to always read,
    so the setting can be removed.
  3. _get_qa_comment_scores: Take cid_tree as input

    bsimpson63 committed Jun 28, 2016
    Previously it wasn't clear that the CommentTree would be looked up and
    that there might be some consistency concerns.
  4. write_comment_orders: Add counters to track writes vs. noops

    bsimpson63 committed Nov 9, 2016
    This will let us get a sense of how much work is actually done. I'm looking
    at splitting the CommentOrderer update out into a separate queue and need
    to understand how many writes actually happen.
  5. add_comments: Remove warning about writing scores first

    bsimpson63 committed Jun 28, 2016
    This warning was no longer true--any missing scores are automatically
    calculated and updated.
    
    We actually have the opposite issue--the CommentTree must be updated
    before writing scores because the QA score reads it.
  6. voting: Don't update comment scores on automatic initial vote

    bsimpson63 committed Nov 10, 2016
    Score updates are processed through commentstree_q. When a new comment
    is created an automatic initial vote (by the comment's author) is created.
    This results in two messages in commentstree_q: one from the vote and one
    from queries.new_comments. Don't create the message from the vote because it
    is redundant. This will let us reduce the volume of messages in commentstree_q
    which is currently very high.
  7. feature: Fix race condition when live_config is updated

    bsimpson63 committed Nov 8, 2016
    Instead of checking _featurestate_cache for a key's existence and then
    retrieving it, just get it and then check for a miss. Doing the two step
    process can result in a KeyError if _featurestate_cache is cleared between
    the existence check and the retrieval.
  8. db_manager: Don't setup a connection for some dbs on startup

    bsimpson63 committed Nov 8, 2016
    "email", "authorize", "hc", and "traffic" databases aren't used that
    often and maybe we can reduce the number of connections to pg-05 by
    waiting to establish a connection until it's actually needed.
Commits on Nov 3, 2016
  1. voting: Don't use fastlane vote processor

    bsimpson63 committed Nov 3, 2016
    The fastlane processor was meant to handle votes on both Links and Comments,
    but it can't do that easily anymore now that the vote processing has been
    split. It's not a big deal now because Link vote processing is much faster
    now that the query updating has been separated and sharded. The Comment vote
    consumer/queue was getting some benefit from the fastlane and it can be
    resurrected if we run into problems.