Skip to content
This repository has been archived by the owner. It is now read-only.

Perserve the originally attempted title when resubmitting a link. #1309

Closed

Conversation

@Pokechu22
Copy link
Contributor

Pokechu22 commented May 1, 2015

Hello! /u/pokechu22 here. I've added support for saving the current title when resubmitting a link, in the same way that 1c8a271 did with the full URL.

@@ -286,7 +286,8 @@ def GET_comments(
infotext = None
if request.GET.get('already_submitted'):
submit_url = request.GET.get('submit_url') or article.url
resubmit_url = Link.resubmit_link(submit_url)
submit_title = request.GET.get('submit_title') or article.title

This comment has been minimized.

Copy link
@bsimpson63

bsimpson63 May 1, 2015

Contributor

Is it really appropriate to use article.title as the fallback? Wouldn't it be better to not pre-fill a title at all?

This comment has been minimized.

Copy link
@Pokechu22

Pokechu22 May 1, 2015

Author Contributor

I can see some use, although it doesn't seem too common.

If someone wants to resubmit an article, this way it would automatically supply the title as well. But I see this as being very rare. I feel like it could go either way.

This comment has been minimized.

Copy link
@bsimpson63

bsimpson63 Jul 29, 2015

Contributor

I think it's be less confusing to not pre-fill a title at all. Could you make that change?

@Pokechu22 Pokechu22 force-pushed the Pokechu22:perserve-title-on-resubmit branch from 1220030 to f82ada1 Jul 29, 2015
@Pokechu22
Copy link
Contributor Author

Pokechu22 commented Jul 29, 2015

💇

@bsimpson63
Copy link
Contributor

bsimpson63 commented Jul 29, 2015

Thanks, this looks good. I'm going to test it a bit and then will get it merged.

@bsimpson63
Copy link
Contributor

bsimpson63 commented Jul 30, 2015

Merged as c942cef

What's your reddit username so I can give you a trophy?

@bsimpson63 bsimpson63 closed this Jul 30, 2015
@Pokechu22
Copy link
Contributor Author

Pokechu22 commented Jul 30, 2015

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.