From de1b27baf8afae960a664c503a498ff62cb9a958 Mon Sep 17 00:00:00 2001 From: Pascal Lalonde Date: Tue, 25 Feb 2025 15:05:26 -0500 Subject: [PATCH 1/3] Rename baseplate_log_latency_seconds to baseplate_logger_write_duration_seconds The new name makes it clear that this captures the duration of local logging calls as opposed to end-to-end logging latency to the centralized collector. --- log/core_wrapper.go | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/log/core_wrapper.go b/log/core_wrapper.go index c42b2ca6d..706f5467b 100644 --- a/log/core_wrapper.go +++ b/log/core_wrapper.go @@ -13,9 +13,9 @@ import ( ) var ( - logLatencySeconds = promauto.With(prometheusbpint.GlobalRegistry).NewHistogram( + loggerWriteDurationSeconds = promauto.With(prometheusbpint.GlobalRegistry).NewHistogram( prometheus.HistogramOpts{ - Name: "baseplate_log_latency_seconds", + Name: "baseplate_logger_write_duration_seconds", Help: "Latency of log calls", Buckets: []float64{ 0.000_005, @@ -45,7 +45,7 @@ func (w wrappedCore) With(fields []zapcore.Field) zapcore.Core { func (w wrappedCore) Write(entry zapcore.Entry, fields []zapcore.Field) error { defer func(start time.Time) { - logLatencySeconds.Observe(time.Since(start).Seconds()) + loggerWriteDurationSeconds.Observe(time.Since(start).Seconds()) }(time.Now()) return w.Core.Write(entry, wrapFields(fields)) } From aa806d9aa4dcc45169f48c0767a0e760d64a7f9f Mon Sep 17 00:00:00 2001 From: Pascal Lalonde Date: Tue, 25 Feb 2025 16:01:13 -0500 Subject: [PATCH 2/3] Name metric after its baseplate component: logger -> log --- log/core_wrapper.go | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/log/core_wrapper.go b/log/core_wrapper.go index 706f5467b..c93447c01 100644 --- a/log/core_wrapper.go +++ b/log/core_wrapper.go @@ -13,9 +13,9 @@ import ( ) var ( - loggerWriteDurationSeconds = promauto.With(prometheusbpint.GlobalRegistry).NewHistogram( + logWriteDurationSeconds = promauto.With(prometheusbpint.GlobalRegistry).NewHistogram( prometheus.HistogramOpts{ - Name: "baseplate_logger_write_duration_seconds", + Name: "baseplate_log_write_duration_seconds", Help: "Latency of log calls", Buckets: []float64{ 0.000_005, @@ -45,7 +45,7 @@ func (w wrappedCore) With(fields []zapcore.Field) zapcore.Core { func (w wrappedCore) Write(entry zapcore.Entry, fields []zapcore.Field) error { defer func(start time.Time) { - loggerWriteDurationSeconds.Observe(time.Since(start).Seconds()) + logWriteDurationSeconds.Observe(time.Since(start).Seconds()) }(time.Now()) return w.Core.Write(entry, wrapFields(fields)) } From fc659a886e931a1deb514d412958215aa033585c Mon Sep 17 00:00:00 2001 From: Pascal Lalonde Date: Wed, 26 Feb 2025 11:22:15 -0500 Subject: [PATCH 3/3] Update help: log calls -> log writes --- log/core_wrapper.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/log/core_wrapper.go b/log/core_wrapper.go index c93447c01..811257538 100644 --- a/log/core_wrapper.go +++ b/log/core_wrapper.go @@ -16,7 +16,7 @@ var ( logWriteDurationSeconds = promauto.With(prometheusbpint.GlobalRegistry).NewHistogram( prometheus.HistogramOpts{ Name: "baseplate_log_write_duration_seconds", - Help: "Latency of log calls", + Help: "Latency of log writes", Buckets: []float64{ 0.000_005, 0.000_010,