Skip to content


Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
branch: master
Commits on Mar 4, 2015
  1. James Pearson

    Email validator: don't allow multiple hostnames

    xiongchiamiov authored
    In addition to not allowing `@` multiple times in the string, we're now
    checking that the *entire* string matches our regex - previously, you could
    tack on anything to the end of a valid email address and have it succeed.
  2. James Pearson

    Email validator: don't allow whitespace in the address

    xiongchiamiov authored
    See sections 3.4.1 and 3.2.4 of RFC 2822.
    From my reading, you can *technically* include whitespace if it's quoted, but
    for our purposes it's almost certainly going to be a mistake we want to notify
    the user about.
  3. James Pearson

    Email validator: add basic tests

    xiongchiamiov authored
    Email addresses are super funky - there are a lot of things that are allowed
    that you wouldn't expect.  We're not going to try to conform perfectly to the
    RFCs, but a set of tests helps us not break some commonly-used odd cases and
    prevent regressions when we make fixes.
  4. James Pearson

    Consolidate email logic

    xiongchiamiov authored
    Using two copies of one regex for validating email addresses is just asking for
    trouble, so now they're merged back into one that `ValidEmail` and
    `ValidEmails` share.
  5. Ricky Ramirez
  6. Ricky Ramirez
  7. Brian Simpson
  8. Keith Mitchell

    Rename and document `stacked_proxy_safe_get`

    kemitche authored
    Clarify its purpose and why attribute access might raise
    TypeError instead of AttributeError.
  9. Keith Mitchell
  10. florenceyeun

    Subreddit settings: Custom subreddit color

    florenceyeun authored
    Add a custom color field with HTML5 color picker when available.
  11. Brian Simpson
  12. Matthew Lee

    markdown: Move variables to colors.less.

    madbook authored
    colors.less is imported by variables.less
  13. Matthew Lee
  14. Matthew Lee
  15. Matthew Lee

    markdown: Fix selftext style when editing.

    madbook authored
    When I changed markdown.less to be imported directly instead of being loaded
    separately, the behavior of less's ':extend' caused the usertext input to
    inherit some extra styles, including the non-editable styles.  It is fixed
    by applying the 'md' and 'md-container' classed directly to the elements rather
    than using less's extend feature.
Commits on Mar 3, 2015
  1. Matthew Lee

    markdown: Remove feature flags and import markdown.less directly.

    madbook authored
  2. Matthew Lee
  3. Matthew Lee
  4. Matthew Lee

    markdown: Fix text size on submit pages.

    madbook authored
    Another spot with markdown text that I missed.  Text was getting really
    big here due to the missing .md-container class.
  5. James Pearson

    Orangered emails: include sender's name

    xiongchiamiov authored
    @umbrae pointed out that it's nice to know who a message is from, even if you
    have to go to the message on the web to reply.
    It's possible at some point in time we will need something else from the sender
    than just their username.  However, sending the id and causing a lookup seems
    unnecessary for a vague possibility - and we should be able to make a
    transition in the future pretty easily if necessary.
  6. James Pearson

    Orangered emails: one-click unsubscribe

    xiongchiamiov authored
    Even if it's opt-in, we want people to be able to easily unsubscribe from
    notification emails.
    Using an HMAC instead of a generated token means we don't have to store
    anything extra, but just perform a calculation on email send and in the
    unsubscribe responder.
  7. James Pearson

    Orangered emails: send from alternate address

    xiongchiamiov authored
    Despite our best efforts, we're probably still going to appear a bit spammy
    with our notification emails.  To help prevent this from affecting everything
    else, we can send these from an alternate domain.
  8. James Pearson

    Orangered emails: don't escape entities

    xiongchiamiov authored
    @umbrae and @powerlanguage both noticed that certain characters (angle
    brackets, quotes) were being html-escaped in the emails.  Since the emails are
    currently only plaintext, this looked weird and required a mental translation
    back to understand what the prior markdown looked like.
    This should continue to be safe as long as we're only sending plaintext emails.
  9. James Pearson

    Notification emails: add safety switch

    xiongchiamiov authored
    This is just sort of a "if something is going terribly wrong, shut it down to
    avoid breaking other things relying on email" sort of thing.
  10. James Pearson

    TryLater: use more generic parameter name

    xiongchiamiov authored
    `mature_items` made sense in the original context, but now that I'm stealing it
    for other uses it's really just some set of some sort of data.
  11. James Pearson

    Add option for sending orangereds as emails

    xiongchiamiov authored
    Some users visit fairly infrequently, or visit without being logged-in, and so
    [don't notice messages they've received][0].  We need some better data on this,
    and it's hard to separate these people out from alts (particularly novelty
    accounts).  However, [anecdotal evidence][1] and conversations shows that there
    is *some* demand for this feature.
    There are a lot more things to do to get this ready for public usage.  However,
    we just want to get a quick prototype out so that we can start using it
    internally and see where it falls apart.
  12. James Pearson

    Mail queue: comment expansion and clarification

    xiongchiamiov authored
    Thanks to Neil and Keith for helping me track down the why.
  13. James Pearson

    Document trylater module

    xiongchiamiov authored
    I mostly pulled this from the usage in `models/`, plus some feedback
    from @atiaxi.
  14. Melissa Cole
  15. Melissa Cole

    Pass in gold_subscr_id for stripe cancellations

    MelissaCole authored
    Account might not always contain the gold_subscr_id, so passing in the subscr_id
    to the stripe cancellation function instead of the Account object will handle
    these cases.
  16. Melissa Cole
  17. Melissa Cole
  18. Jordan Milne
  19. Jordan Milne
  20. Jordan Milne

    Omit cloudsearch fields if they contain private info

    JordanMilne authored
    Specifically, link author names were not being scrubbed when their
    account was deleted. Some subreddit attrs needed to be scrubbed too,
    but weren't actually leakable due to the subreddit search endpoint
    being restricted to the 'plain' syntax.
Something went wrong with that request. Please try again.