Permalink
Commits on Jan 19, 2017
Commits on Jan 12, 2017
  1. search: Disable faceting

    Faceting returns counts of query matches per subreddit name so we can
    show the user all the subreddits that contain links for their query.
    This ends up returning many unpopular subreddits, which when looked up
    by name are often missing from cache and result in a postgres query. This
    is bad for performance, and the feature is not popular with users so it is
    safe to remove.
    bsimpson63 committed Jan 11, 2017
Commits on Jan 4, 2017
  1. Sanitize trailing ? when stripping analytics parameters from URL

    Safari doesn't remove the ? from a URL when setting `url.search = ''`
    which results in links not correctly applying `:visited`.
    
    For example, before this change:
    https://www.reddit.com/?utm_foo=bar -> https://www.reddit.com/?
    and links to https://www.reddit.com/ don't render as :visited
    
    After this change,
    https://www.reddit.com/?utm_foo=bar -> https://www.reddit.com/
    and links to https://www.reddit.com/ are properly empurpled.
    Additionally, hash is preserved:
    https://www.reddit.com/?utm_foo=bar&baz=qux#hoopla -> https://www.reddit.com/?baz=qux#hoopla
    andytuba committed Jan 3, 2017
Commits on Dec 21, 2016
  1. Replace link href with inbound tracking url on click

    If a link has an inbound tracking url (regular url plus utm query parameters)
    or outbound tracking url (redirect via outbound link tracker service),
    then replace the link's `href` with the tracking url when clicked.
    
    This ensures links to the same resource with different tracking details
    (e.g. comments flatlist button vs self-post title vs self-post source-url)
    correctly render as `:visited` despite different `?utm_content=button-name`.
    
    This commit also includes fixes to properly split the cache for rendered
    link and comment templates when inbound tracking URLs are enabled.
    andytuba committed Dec 19, 2016
Commits on Dec 20, 2016
  1. Revert "Generate mobile bi-directional links"

    This reverts commit 920abaf
    wting committed Dec 20, 2016
Commits on Dec 19, 2016
  1. Remove /mobile

    This subdomain is going away, and redirects should be happening via the
    "mobile website" link at the bottom.
    wting committed Dec 16, 2016
Commits on Dec 14, 2016
  1. Remove beta references to 2X.

    wting committed Dec 14, 2016
  2. MultiApiController: fix on_validation_error() to set code

    Some errors don't have a code associated with them so we need to
    supply a default value to abort_with_error. This fixes the
    USER_DOESNT_EXIST errors that are causing exceptions.
    bsimpson63 committed Dec 14, 2016
Commits on Dec 8, 2016
Commits on Dec 2, 2016
  1. Add utm query parameters onto links for comments/messages

    Link.tracking_link adds utm query parameters onto links inside reddit
    to track which button was clicked, what component type contains the button
    (e.g. post listing, inbox, post listing embedded on a comments page),
    what page type the user is visiting, and the page's subreddit.
    
    This feature is enabled via feature flag and disabled by admin mode.
    
    This commit affects programmatically-generated links to comments and messages.
    andytuba committed Nov 4, 2016
Commits on Dec 1, 2016
  1. Search: Fix restrict_sr for domains listings and AllMinus

    For domains listings, it was possible to have results from the wrong domain be included.  Switching to a phrase search fixes that.  See https://redd.it/5ew4ve for more info about, and caveats of, this method.
    
    For AllMinus, see https://redd.it/5eqiyy for the general context.  This does not need to be explicitly handled for ModMinus, as ModMinus excludes the filtered subreddits from its sr_ids property.  Additionally, ModMinus doesn't need special handling since it inherits the already-handled MultiReddit.
    Pokechu22 committed with bsimpson63 Nov 25, 2016
Commits on Nov 29, 2016
  1. Mention karma in CANT_CREATE_SR

    The most common, and I really mean it, the most common post in /r/help and related subreddits is when users question why they can't make a subreddit even though they have an old account. The error that users get only mentions account age and does not mention any kind of karma requirement. It's in the /r/help FAQ, but we all know no one reads that.
    
    Just lightly mentioning karma could reduce the traffic on /r/help as well as be more clear.
    allthefoxes committed with kjoconnor Oct 23, 2016
  2. Ads: Remove roadblocks functionality

    These were original to prevent users from buying ads when
    managed campaign page takeovers were in effect.  With auction this
    no longer matters since impressions are no longer guaranteed.
    
    More recently it seems roadblocks were used to prevent people from
    buying ads in places that were inappropriate.  We now have other
    ways of dealing with that (`subreddit.hide_sponsored_headlines and
    `subreddit.allow_ads`) so these pages are completely obsolete.
    dwick committed with wting Jun 13, 2016
Commits on Nov 28, 2016
  1. Remove unused imports.

    wting committed Nov 2, 2016
  2. Remove unused Cassandra Counter.

    wting committed Nov 2, 2016
Commits on Nov 22, 2016
Commits on Nov 14, 2016
  1. Process updates in non-fastlane queue when a link is fastlaned

    Previously the messages in the non-fastlane queue were dropped so some
    older comments would not be added to the CommentTree. There may be some
    lock contention with multiple queue consumers processing updates for the
    fastlaned links, but it shouldn't last very long.
    bsimpson63 committed Aug 9, 2016
  2. Remove live config "precomputed_comment_sort_read_chance"

    This was used to gradually ramp up reads of the precomputed comment
    orders. We've been running for a while with this set to always read,
    so the setting can be removed.
    bsimpson63 committed Aug 8, 2016
  3. _get_qa_comment_scores: Take cid_tree as input

    Previously it wasn't clear that the CommentTree would be looked up and
    that there might be some consistency concerns.
    bsimpson63 committed Jun 28, 2016
  4. write_comment_orders: Add counters to track writes vs. noops

    This will let us get a sense of how much work is actually done. I'm looking
    at splitting the CommentOrderer update out into a separate queue and need
    to understand how many writes actually happen.
    bsimpson63 committed Nov 9, 2016
  5. add_comments: Remove warning about writing scores first

    This warning was no longer true--any missing scores are automatically
    calculated and updated.
    
    We actually have the opposite issue--the CommentTree must be updated
    before writing scores because the QA score reads it.
    bsimpson63 committed Jun 28, 2016
  6. voting: Don't update comment scores on automatic initial vote

    Score updates are processed through commentstree_q. When a new comment
    is created an automatic initial vote (by the comment's author) is created.
    This results in two messages in commentstree_q: one from the vote and one
    from queries.new_comments. Don't create the message from the vote because it
    is redundant. This will let us reduce the volume of messages in commentstree_q
    which is currently very high.
    bsimpson63 committed Nov 10, 2016
  7. feature: Fix race condition when live_config is updated

    Instead of checking _featurestate_cache for a key's existence and then
    retrieving it, just get it and then check for a miss. Doing the two step
    process can result in a KeyError if _featurestate_cache is cleared between
    the existence check and the retrieval.
    bsimpson63 committed Nov 8, 2016