Skip to content
Commits on May 1, 2016
  1. @spladug

    Add baseplate root spans in queue processors and cron jobs

    spladug committed Mar 24, 2016
    This makes it possible to use baseplate context stuff in queue
    processors and cron jobs.
    
    When decorated with the @with_root_span decorator, cron job functions
    will also do regular g.stats flushing which was missing before.
Commits on Apr 28, 2016
  1. @Deimos

    Reset password page: update text

    Deimos committed Apr 28, 2016
    The text on this page hasn't been updated for years and years, and still
    refers to the dark days where the site used to email the user their
    actual password instead of a reset link.
  2. @bsimpson63

    Thing: add tests

    bsimpson63 committed Apr 11, 2016
  3. @bsimpson63

    Thing.write_things_to_cache: Use add_multi for write safety

    bsimpson63 committed Apr 10, 2016
    When writing the cache after a cache miss + db read we don't want to
    overwrite changes made by another process.
  4. @bsimpson63
  5. @bsimpson63
  6. @bsimpson63
  7. @bsimpson63

    ErrorController: Stop logging the useless exception when c.user unset

    bsimpson63 committed Apr 27, 2016
    The exception isn't a trace from the current point, but from the last
    handled exception. This is not useful and is spamming up the logs.
  8. @Deimos

    Fix context-based Link.stickied value in API

    Deimos committed Apr 25, 2016
    The `stickied` attribute was previously dependent on the current
    subreddit context, meaning that it would only be true when the request
    was "inside" the same subreddit as the Link is stickied in. This is good
    when it's being used for styling purposes since we don't want to style
    sticky posts in places like the front page, but it also meant that the
    value was incorrect in the API when using endpoints like /api/info where
    you're not in the subreddit's context.
    
    This change adds a new `use_sticky_style` onto wrapped Links that has
    the same behavior as `stickied` previously did, and uses that in
    templates for styling decisions. The `stickied` attribute now reflects
    whether the Link is stickied in its subreddit, regardless of the context
    that the info is being displayed in.
Commits on Apr 27, 2016
  1. @bsimpson63

    Thing.get_things_from_cache: Pass stat_subname

    bsimpson63 committed Apr 27, 2016
    This lets us continue to collect hit rates and stale hit rates for
    each Thing subclass.
  2. @bsimpson63
  3. @bsimpson63

    MemcacheLock: add "owns_lock" attribute

    bsimpson63 committed Apr 27, 2016
    Now "have_lock" just means that the lock has been acquired by the process.
    A value of True for "owns_lock" means that this instance of the lock was
    where it was initially acquired, so only this instance can release it.
  4. @spladug

    Catch more thrift exception types

    spladug committed Apr 27, 2016
    This list of transient exceptions should be moved to baseplate, but
    until then this prevents errors in the activity service from causing
    r2 requests to fail.
  5. @spladug
  6. @bsimpson63

    MemcacheLock: return lock on __enter__

    bsimpson63 committed Apr 7, 2016
    This lets us do `with g.make_lock(...) as lock: ...`
  7. @bsimpson63

    Thing: Replace ad hoc locking with get_read_modify_write_lock

    bsimpson63 committed Apr 10, 2016
    Also state that it is needed because of the read-modify-write operation.
  8. @bsimpson63
  9. @bsimpson63
  10. @bsimpson63

    Thing: remove concept of _loaded objects

    bsimpson63 committed Apr 9, 2016
    Once we've been always loading the data props for longer than the TTL
    we'll never encounter unloaded Things.
  11. @umbrae @bsimpson63
  12. @birakattack

    Fix closest call and use normal jquery selector

    birakattack committed Apr 27, 2016
    Using jquery closest returns different values in firefox and chrome. I
    switched the selector being used and that fixed the firefox issue.
  13. @birakattack

    Fix warning when page is unloaded

    birakattack committed Apr 26, 2016
    Moved the warn-on-unload event selector into the event so the latest
    version of the dom element is returned. This fixes the issue where users
    were receiving the unload warning when successfully editing a comment
    from the profile page.
    
    Excluded hidden elements from the jquery selector when validating
    whether a form has dirty elements. This fixed the case where users
    cancelled their edits but the warning was still showing up.
Commits on Apr 26, 2016
  1. @birakattack

    Remove warn-on-unload class form usertext control

    birakattack committed Apr 26, 2016
    Remove the warn-on-unload class temporarily to prevent the warning
    dialog from showing when users edit their comments from the profile
    page.
  2. @birakattack

    Add unload warning for post/link submission forms

    birakattack committed Apr 18, 2016
    Alert the user when they are about to navigate away from the post or
    link submission page if any field in the form is dirty. Requires the
    branch task/web-1067-backend (a71e9a8185bea8a6fd6384a99fda020e48197f50)
    to be deployed.
  3. @bsimpson63
  4. @birakattack

    Add success flag in JQueryResponse.make_response

    birakattack committed Apr 20, 2016
    No way of identifying whether a form has been successfully submitted to
    the POST_submit endpoint. As both success and error responses return a
    200 status code. By adding the success flag we are able to validate
    whether the POST to the endpoint was successful.
Commits on Apr 25, 2016
  1. @bsimpson63

    VSubredditName: return if not valid_name

    bsimpson63 committed Apr 25, 2016
    This avoids passing bad value into `str()`
  2. @bsimpson63

    Vagrantfile: Use current trusty cloud image without hash verification

    bsimpson63 committed Apr 25, 2016
    The images change too frequently. We should work on a solution that
    retrieves the hash for the current image rather than hardcoding it
    into the Vagrantfile.
  3. @bsimpson63
Commits on Apr 21, 2016
  1. @pwildani

    Suggest subjects for messages to subreddits

    pwildani committed Apr 13, 2016
    The suggestions come from the subreddit's rules.
    
    This should help message handling for mods admins by making rules
    violation reports more consistent.
  2. @bsimpson63
  3. @bsimpson63
  4. @bsimpson63
Commits on Apr 20, 2016
  1. @bsimpson63
  2. @bsimpson63
Something went wrong with that request. Please try again.