Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Commits on Mar 26, 2015
  1. @bsimpson63
Commits on Mar 23, 2015
  1. @bsimpson63
  2. @bsimpson63
  3. @bsimpson63
  4. @bsimpson63
  5. @bsimpson63
  6. @bsimpson63
  7. @bsimpson63
Commits on Mar 20, 2015
  1. @xiongchiamiov

    Q&A sort: don't collapse comments on permalink pages

    xiongchiamiov authored
    The comment-hiding behavior of Q&A sort has been confusing when viewing a
    comment permalink, since it is fairly likely all the comments would be hidden.
    This is particularly problematic when the user hasn't explicitly set the sort
    for that page, eg by having it set as their default through the sticky sort
    behavior or due to a subreddit- or thread-default sort.
    
    Now we don't do any hiding of comments due to Q&A sort on permalink pages.
Commits on Mar 19, 2015
  1. @JordanMilne

    Fix several `is_reddit_url()` bypasses

    JordanMilne authored
    Thanks to Yassine ABOUKIR (http://www.yassineaboukir.com) for the report!
    
    `////example.com` doesn't survive the round-trip through
    `urlunparse(urlparse())` and becomes `//example.com`.
    
    Things like `///\t/foo.com` were also getting by because some UAs
    ignore various characters when they occur before the path section.
    `UrlParser.is_web_safe_url()` was added to check if a URL could be
    interpreted differently by different parsers
Commits on Mar 18, 2015
  1. @ThorArakis
Commits on Mar 17, 2015
  1. @kemitche

    Multis: Use weighting_scheme to choose ageweight

    kemitche authored
    When merging subreddits in a Multireddit, use the multireddit's
    weighting_scheme to determine what ageweight to normalize with.
  2. @xiongchiamiov

    Q&A sort type: add special collapsing rules

    xiongchiamiov authored
    In the Q&A sort type, we now collapse everything except:
    
    * top-level posts
    * OP posts
    * the comments preceding OP posts
    
    to help readers find OP interactions.
  3. @xiongchiamiov

    Add new Q&A-oriented sort type

    xiongchiamiov authored
    None of our current sort types work terribly well for Q&A threads.  So, we're
    adding a new one that takes into account not only the votes on top-level
    comments, but the votes on any OP responses, too, as well as the length of both
    comments.
  4. @Deimos
  5. @Deimos

    Refactor flair API endpoints

    Deimos authored
    A lot of the logic related to setting flair was included (and repeated)
    throughout the API endpoints. This commit moves that logic into methods
    on Link and Account, and refactors the endpoints to use those methods
    instead.
  6. @Deimos

    ModAction: move models imports into functions

    Deimos authored
    This will prevent circular imports when importing ModAction into
    Account, Link, etc.
Commits on Mar 16, 2015
  1. @xiongchiamiov

    Comment: fix bad merge resolution

    xiongchiamiov authored
    While fixing merge conflicts, I made an incorrect decision, leading to
    reddit/reddit@9c6aa71 introducing an undefined variable.  This fixes it by
    getting rid of the duplicate block, using the conditional logic introduced in
    reddit/reddit@5712c98 .
  2. @spladug

    vote: Write LastModified in request rather than in queue.

    spladug authored
    This will allow us to trust LastModified for culling lookups to
    prequeued_vote_keys. In a situation of bad queue lag, this could result
    in more lookups going to Cassandra, as the LastModified culling in
    DenomralizedRelation will be thrown off slightly, but that should be OK
    as the bloom filters will catch the negative lookups quickly.
Commits on Mar 13, 2015
  1. @florenceyeun

    Subreddit settings: Use subreddit multi for related subreddits

    florenceyeun authored
    Use a multi to manage a subreddit's related subreddits.
  2. @florenceyeun

    Multireddits for subreddits

    florenceyeun authored
    Allow multis to be associated with subreddits using LabeledMulti.
  3. @florenceyeun

    Multi API: Add subreddit names to copy and rename response

    florenceyeun authored
    POST /api/multi/copy and /api/multi/rename was missing subreddit names.
  4. @florenceyeun

    Multi API: Fix create multi with display_name

    florenceyeun authored
    POST /api/multi with display_name was failing for user's first multi.
Commits on Mar 11, 2015
  1. @bsimpson63
  2. @bsimpson63
Commits on Mar 3, 2015
  1. @xiongchiamiov

    Orangered emails: include sender's name

    xiongchiamiov authored
    @umbrae pointed out that it's nice to know who a message is from, even if you
    have to go to the message on the web to reply.
    
    It's possible at some point in time we will need something else from the sender
    than just their username.  However, sending the id and causing a lookup seems
    unnecessary for a vague possibility - and we should be able to make a
    transition in the future pretty easily if necessary.
  2. @xiongchiamiov

    TryLater: use more generic parameter name

    xiongchiamiov authored
    `mature_items` made sense in the original context, but now that I'm stealing it
    for other uses it's really just some set of some sort of data.
  3. @xiongchiamiov

    Add option for sending orangereds as emails

    xiongchiamiov authored
    Some users visit fairly infrequently, or visit without being logged-in, and so
    [don't notice messages they've received][0].  We need some better data on this,
    and it's hard to separate these people out from alts (particularly novelty
    accounts).  However, [anecdotal evidence][1] and conversations shows that there
    is *some* demand for this feature.
    
    There are a lot more things to do to get this ready for public usage.  However,
    we just want to get a quick prototype out so that we can start using it
    internally and see where it falls apart.
    
    [0]: https://www.reddit.com/r/redditdev/comments/2f12s3/email_notifications/
    [1]: https://ifttt.com/recipes/94391-reddit-inbox-to-email-inbox
  4. @xiongchiamiov

    Mail queue: comment expansion and clarification

    xiongchiamiov authored
    Thanks to Neil and Keith for helping me track down the why.
  5. @xiongchiamiov

    Document trylater module

    xiongchiamiov authored
    I mostly pulled this from the usage in `models/account.py`, plus some feedback
    from @atiaxi.
  6. @JordanMilne
Commits on Feb 28, 2015
  1. @umbrae
  2. @umbrae
  3. @umbrae

    Add "default_comment_sort" option for subreddits.

    umbrae authored
    If a sort has not been explicitly set for a thread, it will fall back to this
    sort. If no sort is provided here, it will be whatever the user's preference
    is.
    
    Conflicts:
    
    	r2/r2/controllers/front.py
    	r2/r2/lib/menus.py
  4. @umbrae

    Add default sort for links, a mod settable parameter.

    umbrae authored
    This adds the base functionality for a default sort for links, wrapped
    behind a feature flag. Still yet to be implemented but necessary for
    general release:
    
    * A user option to disable all suggested sorts
    * An interface for mods to set default sort for a thread
    * A subreddit settings to set the default sort for all threads to the SR
    
    Conflicts:
    
    	r2/r2/controllers/front.py
Something went wrong with that request. Please try again.