Currently sending two copies of each comment header #422

Closed
kemitche opened this Issue Apr 20, 2012 · 2 comments

Projects

None yet

3 participants

@kemitche

comment_skeleton.html currently sends both the collapsed version of a comment and the uncollapsed version.

It seems like it might be better to send just one, and have the collapse/uncollapse logic apply appropriate styles/changes to it.

@chromakode

You'll find many examples in the current frontend where when content needs to be swapped / changed between different modes, it's simply rendered multiple times in the templates. Implementing such UI logic in JS will be cleaner but it's easy to write bloated jQuery code if it's not structured well. Without advocating against changing it in the short term, I think Backbone or another MVC framework will make it much easier to organize such template wrangling code than what we're working with today.

@spladug
reddit member

Fixed by @bsimpson63 in a44c297.

@spladug spladug closed this Dec 16, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment