CSS validator blocks box-shadow property with "inset" value #509

Closed
dambrisco opened this Issue Aug 27, 2012 · 2 comments

Projects

None yet

3 participants

@dambrisco

Should be able to be fixed by changing https://github.com/reddit/reddit/blob/master/r2/r2/lib/cssfilter.py#L111 to:

'box-shadow': 'none|(?:({box-shadow-pos}\s+)?{color}\s+(?:inset)?|({color}\s+?){box-shadow-pos}\s+(?:inset)?)',

I'll get a pull request put together when I'm back home if no one's gotten to this. (My solution only watches for "inset" being added to the end of a declaration, so perhaps someone could put together more comprehensive solution if they so desire.

@benwaffle

please fix

@spladug
reddit member

Fixed in dce6b6d.

@spladug spladug closed this Apr 29, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment