Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

In Firefox, space bar not scrolling when up/down arrow focused #607

Open
serhalp opened this Issue · 5 comments

3 participants

Philippe Serhal Max Goodman Keith Mitchell
Philippe Serhal

As of about a week or two, space and shift-space can no longer be used to scroll the page when an upvote or downvote arrow is focused, specifically in recent versions of Firefox.

Steps to reproduce:

  1. Open reddit in Firefox >= 17.0
  2. Upvote or downvote a submission or comment
  3. Hit space (nothing happens)
  4. Click anything other than an arrow (e.g. background)
  5. Hit space (page scrolls)

Sorry I haven't run extensive tests on various OSes/browsers/versions, but I can confirm this bug is present on the following:

  • OS X 10.5.8, Firefox 17.0
  • Linux, Firefox 18.0
  • Windows XP, 17.0

And I can confirm everything works as expected on Chrome on all three platforms.

Philippe Serhal

For what it's worth, I've taken a look at the Firefox 17.0 release notes and perused the full bug list, but I haven't seen anything that appears to be relevant. So my hunch is that this is due to a reddit code change.

Max Goodman

That would probably be the tabindex=0 change here: 2ddfab7

Philippe Serhal

Hmm, yeah. I can confirm that removing tabindex="0" via Firebug fixes it.

Any idea for a workaround?

Philippe Serhal

I could see just letting this be as is if the space bar actually fired the button, but as it is, it neither votes nor scrolls, which makes very little sense.

Hrm, I've tried a few things, such as getting the keyup/keydown/keypress handlers on the arrows to call .preventDefault() on the event, but that doesn't appear to be working. Any idea as to what Firefox is doing here exactly?

Philippe Serhal

So, are there no plans to address this at all? To summarize, Firefox users can no longer scroll a page with the space bar after having voted on that page. This is a bad thing.

Keith Mitchell kemitche closed this
Keith Mitchell kemitche reopened this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.