This repository has been archived by the owner. It is now read-only.

global_conf and app_conf mutable arguments #411

Closed
wants to merge 2 commits into
from

Conversation

Projects
None yet
2 participants

shawnps commented Apr 12, 2012

I'm gonna grab the vagrant box later tonight and test this, but basically it's better to not use mutable default values:

http://effbot.org/zone/default-values.htm

shawnps added some commits Apr 12, 2012

set global_conf and app_conf arguments to None in environment.py load…
…_environment, then check them or set them to empty dict
Owner

spladug commented Nov 20, 2012

While I understand the reasoning behind this change, I think it's unnecessary since load_environment is only called once per process by design. Thanks for the pull request.

@spladug spladug closed this Nov 20, 2012

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.