Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Removed unnecessary import #497

Closed
wants to merge 1 commit into from

2 participants

@mttr

Calling 'import pylon.config' (which is not an actual module) was breaking the build process...

@mttr mttr Removed 'import pylons.config', since it was unnecessary and broke th…
…e 'make pyx' process (since pylons.config isn't an actual module...)
784abd0
@chromakode

pylons.config is definitely an actual importable python object and is used in several places in this file. It sounds like something else is amiss with your build environment. If you'd like help figuring it out, please send a description of the error to our mailing list or dev IRC channel.

@chromakode chromakode closed this
@mttr

According to the documentation for Pylons, pylons.config is a global object contained within the pylons module--in which case, the proper way to import it is with from pylons import config. But even that's not necessary since pylons is already imported in that file, and can be referenced by using pylons.config (which it already is).

@chromakode

Gotcha. You are correct that the import can be pruned. Reopening.

@chromakode chromakode reopened this
@chromakode

Merged, thank you! :)

312da0e

@chromakode chromakode closed this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Aug 17, 2012
  1. @mttr

    Removed 'import pylons.config', since it was unnecessary and broke th…

    mttr authored
    …e 'make pyx' process (since pylons.config isn't an actual module...)
This page is out of date. Refresh to see the latest.
Showing with 0 additions and 1 deletion.
  1. +0 −1  r2/r2/lib/translation.py
View
1  r2/r2/lib/translation.py
@@ -23,7 +23,6 @@
import json
import os
import pylons
-import pylons.config
from pylons.i18n.translation import translation, LanguageError, NullTranslations
try:
Something went wrong with that request. Please try again.