Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

When viewing compact Reddit in landscape mode, long titles overflow incorrectly. #501

Closed
wants to merge 2 commits into from

3 participants

@rolmos

Fixes overflow issues with long titles in mobile landscape view. http://i.imgur.com/bgtvg.png

@rolmos rolmos Update r2/r2/public/static/css/compact.scss
Fixes overflow issues with long titles.
275f40b
@spladug
Owner

Sadly, we've got the Sass-source and compiled CSS in the repo right now (as we don't want sass to be a dependency), so any changes you make to compact.scss will also need to be replicated in compact.css. :(

@rolmos

I can do that, it's just one line of code to modify in the compiled CSS. I'm just extremely noobish with GIT, so I'll take a bit to do it.

@chromakode

Looks good, thanks for the fix!

@chromakode

Merged, thank you. :)

102e83f

@chromakode chromakode closed this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Aug 19, 2012
  1. @rolmos

    Update r2/r2/public/static/css/compact.scss

    rolmos authored
    Fixes overflow issues with long titles.
Commits on Aug 22, 2012
  1. @rolmos
This page is out of date. Refresh to see the latest.
View
2  r2/r2/public/static/css/compact.css
@@ -148,7 +148,7 @@ body[orient="landscape"] > #topbar > h1 { margin-left: -125px; width: 250px; }
.link .arrow.downmod, .comment .arrow.downmod, .message .arrow.downmod { background-image: url("../compact/downvote-active.png"); /*SPRITE*/ }
/*Links*/
-.link { min-height: 70px; border-bottom: 1px solid #999; border-top: 1px solid #ddd; padding: 5px 5px; padding-bottom: 0px; -moz-box-sizing: border-box; -webkit-box-sizing: border-box; -ms-box-sizing: border-box; box-sizing: border-box; background: rgba(255, 255, 255, 0.6); position: relative; }
+.link { min-height: 70px; border-bottom: 1px solid #999; border-top: 1px solid #ddd; padding: 5px 5px; padding-bottom: 0px; -moz-box-sizing: border-box; -webkit-box-sizing: border-box; -ms-box-sizing: border-box; box-sizing: border-box; background: rgba(255, 255, 255, 0.6); position: relative; overflow: hidden;}
.link:first-child { border-top: none; }
View
1  r2/r2/public/static/css/compact.scss
@@ -516,6 +516,7 @@ body[orient="landscape"] > #topbar > h1 {
@include box-sizing(border-box);
background: rgba(255,255,255,.6);
position: relative;
+ overflow: hidden;
}
.link:first-child {
border-top: none;
Something went wrong with that request. Please try again.