Subreddit admin updates #536

Closed
wants to merge 9 commits into
from

Projects

None yet

3 participants

@andre-d
Contributor
andre-d commented Sep 20, 2012
  • Makes the prev values optional parameters
  • Adds in various missing errors
  • Corrects a bug with VInt when a max and/or a min is not specified.
  • Corrects a bug relating to description/sidebar not being applied on creation Corrects a bug where "saved" would overwrite a conflict error status
@spladug spladug commented on an outdated diff Sep 21, 2012
r2/r2/controllers/api.py
@@ -1530,7 +1530,8 @@ def apply_wikid_field(sr, form, pagename, value, prev, field, error):
form.has_errors('public_description', errors.TOO_LONG) or
form.has_errors('description', errors.TOO_LONG)):
pass
-
+ elif form.has_error():
@spladug
spladug Sep 21, 2012 Member

How does this interact with the stuff on L1655?

@andre-d
Contributor
andre-d commented Sep 25, 2012

Updated to reflect various issues found, tested, and to fix #541

@kemitche kemitche commented on an outdated diff Sep 28, 2012
r2/r2/controllers/api.py
report, parsed = c.site.parse_css(stylesheet_contents)
-
+ prevstyle = request.post.get('prevstyle')
@kemitche
kemitche Sep 28, 2012 Contributor

I don't understand the need for this line

@spladug
Member
spladug commented Sep 28, 2012

Merged

@spladug spladug closed this Sep 28, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment