Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Cleanup CSS3 rules #554

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
3 participants
Contributor

xPaw commented Oct 10, 2012

I didn't touch gradients (maybe will do later)

Contributor

xPaw commented Dec 18, 2012

It's been 2 months, and wasn't even commented on :(

thor commented Dec 18, 2012

I'll give you a comment!

From the looks of it, I'm not spotting any regressions. Then again, it's just some cute and innocent CSS.

One slightly relevant, but not to your actual edits: shouldn't properties with rgba or hsla have a fallback to a solid color?

Contributor

xPaw commented Dec 18, 2012

shouldn't properties with rgba or hsla have a fallback to a solid color?

Yes, they should.

Contributor

xPaw commented Mar 29, 2013

I guess there's no point in leaving this pull request open?

Contributor

Deimos commented Mar 29, 2013

The CSS file doesn't even exist in the repository any more (we use LESS now), so that would be correct. If you want to apply similar changes to the LESS file we could look at it, I expect this pull probably got overlooked due to the impending switch to LESS.

Sorry for the lack of response, thanks for submitting it.

@Deimos Deimos closed this Mar 29, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment