Fix unexpected NO_EMAILS error for /api/update when users remove their email. #733

Closed
wants to merge 1 commit into
from

Projects

None yet

2 participants

@buddydvd
Contributor
buddydvd commented Apr 5, 2013

For /api/update, fix unexpected NO_EMAILS error when users remove their email.

@bsimpson63 bsimpson63 commented on the diff Apr 10, 2013
r2/r2/controllers/api.py
@@ -896,7 +896,8 @@ def POST_update(self, form, jquery, email, password, verify):
# user is removing their email
if (not email and c.user.email and
- form.has_errors("email", errors.NO_EMAILS)):
@bsimpson63
bsimpson63 Apr 10, 2013 Member

Why did you change how we're checking for the error?

@bsimpson63
Member

Can you explain the incorrect behavior a little? Is the issue that the NO_EMAILS error is being sent in the response?

@bsimpson63
Member

🐟 looks good

@bsimpson63
Member
@bsimpson63 bsimpson63 closed this Apr 16, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment