Skip to content

Cleaning up the controllers. #939

Closed
wants to merge 1 commit into from

2 participants

@mssola
mssola commented Dec 30, 2013
  • Removed unneeded imports.
  • Removed variables that were set and never used.
@mssola mssola Cleaning up the controllers.
  - Removed unneeded imports.
  - Removed variables that were set and never used.
1f0032d
@Deimos
reddit member
Deimos commented Feb 7, 2014

Thanks for submitting, but this type of clean-up is risky since we unfortunately don't have the ability to easily test and make sure that there aren't any unexpected effects due to strange cases like import-chains.

We usually try to do this sort of clean-up in a more targeted manner, when a person is working on changes in the same area and has a good understanding of any possible connotations. Since some of the code left behind here after your changes doesn't have any function, it appears that this was just done by clearing warnings in some sort of tool without that level of deeper understanding.

@Deimos Deimos closed this Feb 7, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.