Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lock htauth gem version to 2.0.0 #34

Closed
wants to merge 1 commit into from

Conversation

torjeh
Copy link

@torjeh torjeh commented Apr 2, 2020

htauth was upgraded April 2nd 2020 to version 2.1.1 and now requires bcrypt that needs to be compiled at runtime. Currently this breaks the cookbook for environments where this is not possible.

This is a workaround to make sure that we keep using the same version of htauth that has been used for a long time now.

@copiousfreetime
Copy link

@torjeh funnily enough - the reason that I updated htauth was because of the need for bcrypt2 htpasswd files from folks using chef cookbook (copiousfreetime/htauth#12).

I haven't been a chef user in a long time, do you have any suggestions on a solution to support everyone? The only one that immediately comes to mind is to use a pure ruby bcrypt library, and I don't think there is one.

@copiousfreetime
Copy link

copiousfreetime commented Apr 2, 2020

I got some feedback form the bcrypt folks in bcrypt-ruby/bcrypt-ruby#224

What's probably a better solution for your library's users is to use some combination of bundle package and bundle install --local to use a precompiled .gem package in your vendor/cache.

I don't know if that helps or not. Of if that is even applicable to chef cookbooks

@torjeh
Copy link
Author

torjeh commented Apr 3, 2020

Hi @copiousfreetime

Thank you so much for looking into this! I guess I should have created an issue instead of a pull request, maybe. The discussion is certainly helpful for us.

I guess for us we will first constrain the version of the gem to 2.0.0 in our wrapper cookbooks, and do a proper upgrade at a later point. I am not 100% sure how we will proceed.

We were a bit surprised that our chef clients suddenly tried to install a newer version of a gem, since we have our coookbook versions locked in a Chef policyfiles. So we were not expecting any changes, but we forgot about the gems :)

@derhecht
Copy link

would be great to have this on default - i have to edit this atm on my own

Copy link

@derhecht derhecht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

revert my approve - as we do need 2.1 htauth to work properly - htpasswd has to be fixed to work with new htauth - never the less i got the same compile errors

@ramereth
Copy link
Contributor

I believe #41 has resolved this and has been released as 1.0.0. Please re-open if that isn't the case.

@ramereth ramereth closed this Sep 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants