Update controller-gen #1921
Merged
Update controller-gen #1921
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stuartwdouglas
force-pushed
the
controller-gen-update
branch
from
bac434e to
304a72f
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1921 +/- ##
============================================
+ Coverage 39.08% 39.35% +0.27%
Complexity 752 752
============================================
Files 301 260 -41
Lines 14053 9017 -5036
Branches 1435 1435
============================================
- Hits 5492 3549 -1943
+ Misses 7916 5065 -2851
+ Partials 645 403 -242 ☔ View full report in Codecov by Sentry. |
Collaborator
|
Can you explain this change a bit more? |
Contributor
Author
|
It is just a version update, of the kubebuilder generator (i.e. the bit that generates the CRDs from the model classes). |
stuartwdouglas
force-pushed
the
controller-gen-update
branch
from
304a72f to
7d784e9
Compare
Collaborator
|
For posterity, the failing test was fixed in #1960 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.