Minikube CI and development changes #2077
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Skipping CI for Draft Pull Request. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2077 +/- ##
============================================
- Coverage 39.52% 39.51% -0.02%
+ Complexity 812 811 -1
============================================
Files 301 301
Lines 14145 14145
Branches 1467 1467
============================================
- Hits 5591 5589 -2
- Misses 7906 7907 +1
- Partials 648 649 +1 ☔ View full report in Codecov by Sentry. |
rnc
changed the title
rnc
force-pushed
the
KJB40
branch
2 times, most recently
from
e058341 to
480bab2
Compare
Collaborator
Author
|
/retest |
1 similar comment
Collaborator
Author
|
/retest |
Member
|
/approve |
Member
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes follow on from #2066 and #2067 in order to make it easier for developers to run the minikube CI tests locally.
In this PR I've vastly simplified the
minikube-ci.shscript so it mostly completely relies upon theminikube-development.shscript but also passes the--cleanoption which inbase-development.shwill clean out old runs. This allows local users to reuse it. All defaults have been moved tobase-development.shwhich makes long term maintenance simpler. All scripts now use/bin/bashas on GHActions/bin/shlinks to dash giving unexpected side-affects.NOTE : I have set JBS_S3_SYNC_ENABLED to default to false in this PR.
While there are still two
TODOgiven its unclear if those CRD or secrets are actually needed for minikube development I've left them commented out for now so this could be potentially revisited in future.